Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add governance module special handling #14

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

eloylp
Copy link
Member

@eloylp eloylp commented Jan 8, 2025

Describe the changes

Adds the the special handling logic so the relayer can execute it's amplifier api received tasks
against the gov module GMP processing logic.

Related Issue(s)

https://github.com/eigerco/axelar-relayer-core-internal/issues/28

Checklist

  • Tests have been added/updated for the changes.
  • Documentation has been updated for the changes (if applicable).
  • The code follows Rust's style guidelines.

Additional Context
Had to update the axelar-solana-governance dep for getting the latest code.

@eloylp
Copy link
Member Author

eloylp commented Jan 8, 2025

What would be the best way of testing this 🤔

@eloylp eloylp requested a review from tilacog January 8, 2025 16:44
@roberts-pumpurs
Copy link
Member

We don't have any tests for this component. I am still working on adding tests to event ingestion, but the same approach can be done here. Link to my diff. But my code still depends on an unmerged branch. I will try finishing it today and this will unblock testing the evm->solana flow as well.

Copy link
Member

@roberts-pumpurs roberts-pumpurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently lgtm.
Feel free to merge, create a new issue for missing tests -- let's tackle that later

@eloylp
Copy link
Member Author

eloylp commented Jan 9, 2025

currently lgtm.
Feel free to merge, create a new issue for missing test

Nice, i will create the issue thanks for review. Merging !

@eloylp eloylp merged commit 3219f4b into main Jan 9, 2025
6 checks passed
@eloylp eloylp deleted the govenance-special-handling branch January 9, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants