-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: relayer -> its flow #17
Conversation
bc83005
to
7009371
Compare
7009371
to
9535416
Compare
Signed-off-by: Guilherme Felipe da Silva <[email protected]>
9535416
to
2e40075
Compare
This is due to the fact that the gas service id has changed. Signed-off-by: Guilherme Felipe da Silva <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good for me 👍 Seems most of the logic can be somehow re-used for other program integration tests, like the governance.
Only comment is: Are we manually copying the contracts bytecode to the test/fixtures folder ? No action needed on this PR, but probably good to checkout main from programs repo.
PS: I think relayer is gonna have a beautiful readme :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
task_sender.close_channel(); | ||
let _result = pusher_task.await; | ||
|
||
assert_eq!(rx_amplifier.next().await, None); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add an assert for validating that the state on Solana has changed? (eg the expected PDAs have been initialised). This will give us guarantee that we actually send a tx to the chain
Yeap that's a manual process right now |
Signed-off-by: Guilherme Felipe da Silva <[email protected]>
Describe the changes
Add a few tests for relaer -> ITS flow, specially to check the `its-instruction-builder' is working as expected.
Related Issue(s)
Closes https://github.com/eigerco/solana-axelar-internal/issues/626
Checklist