Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: relayer -> its flow #17

Merged
merged 3 commits into from
Jan 22, 2025
Merged

test: relayer -> its flow #17

merged 3 commits into from
Jan 22, 2025

Conversation

frenzox
Copy link
Contributor

@frenzox frenzox commented Jan 17, 2025

Describe the changes
Add a few tests for relaer -> ITS flow, specially to check the `its-instruction-builder' is working as expected.

Related Issue(s)
Closes https://github.com/eigerco/solana-axelar-internal/issues/626

Checklist

  • Tests have been added/updated for the changes.
  • Documentation has been updated for the changes (if applicable).
  • The code follows Rust's style guidelines.

@frenzox frenzox force-pushed the test/relayer-its-flow branch from bc83005 to 7009371 Compare January 21, 2025 12:37
@frenzox frenzox changed the title tests: relayer -> its flow test: relayer -> its flow Jan 21, 2025
@frenzox frenzox force-pushed the test/relayer-its-flow branch from 7009371 to 9535416 Compare January 21, 2025 12:40
@frenzox frenzox marked this pull request as ready for review January 21, 2025 12:40
Signed-off-by: Guilherme Felipe da Silva <[email protected]>
@frenzox frenzox force-pushed the test/relayer-its-flow branch from 9535416 to 2e40075 Compare January 21, 2025 12:43
This is due to the fact that the gas service id has changed.

Signed-off-by: Guilherme Felipe da Silva <[email protected]>
eloylp
eloylp previously approved these changes Jan 21, 2025
Copy link
Member

@eloylp eloylp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good for me 👍 Seems most of the logic can be somehow re-used for other program integration tests, like the governance.

Only comment is: Are we manually copying the contracts bytecode to the test/fixtures folder ? No action needed on this PR, but probably good to checkout main from programs repo.

PS: I think relayer is gonna have a beautiful readme :D

Copy link
Member

@roberts-pumpurs roberts-pumpurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

task_sender.close_channel();
let _result = pusher_task.await;

assert_eq!(rx_amplifier.next().await, None);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add an assert for validating that the state on Solana has changed? (eg the expected PDAs have been initialised). This will give us guarantee that we actually send a tx to the chain

@roberts-pumpurs
Copy link
Member

@eloylp

Only comment is: Are we manually copying the contracts bytecode to the test/fixtures folder ? No action needed on this PR, but probably good to checkout main from programs repo.

Yeap that's a manual process right now

Signed-off-by: Guilherme Felipe da Silva <[email protected]>
@frenzox frenzox dismissed stale reviews from roberts-pumpurs and eloylp via 9889e0c January 22, 2025 10:13
@frenzox frenzox self-assigned this Jan 22, 2025
@frenzox frenzox merged commit baf5d63 into main Jan 22, 2025
6 checks passed
@frenzox frenzox deleted the test/relayer-its-flow branch January 22, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants