feat: accurate gas calculation for Amplifier API reporting #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roberts-pumpurs
commented
Jan 21, 2025
roberts-pumpurs
force-pushed
the
rob/accurate-gas-calculation
branch
from
2f3861b to
c8edf3e
Compare
roberts-pumpurs
force-pushed
the
rob/accurate-gas-calculation
branch
from
2511cd4 to
452159f
Compare
eloylp
reviewed
Jan 21, 2025
There was a problem hiding this comment.
It overall looks good to me 👍 but take my review with pinct of salt, as i am not fullly familiar with the code yet. I would just fix the CI and get rid of the unwraps (as you already noted).
Maybe in a future we could save some lines of code by improving local test helpers. Not on this PR though, as i think we are still discovering the patterns.
Just sharing one random though that came to my mind was if adding a positive margin to the gas sum (I saw it in other projects) would be needed here ? But probably that's not our job here, as this is only part of the calculation (The Solana side). Such a margin should be added by the last aggregation layer if that's the case.
roberts-pumpurs
force-pushed
the
rob/accurate-gas-calculation
branch
2 times, most recently
from
036b7a8 to
cf1c030
Compare
roberts-pumpurs
force-pushed
the
rob/accurate-gas-calculation
branch
from
cf1c030 to
9aeeed6
Compare
frenzox
reviewed
Jan 22, 2025
frenzox
reviewed
Jan 22, 2025
frenzox
reviewed
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15
Computes the total gas cost (in lamports) for a given Solana transaction, factoring in:
Direct transaction cost.
Additional costs from multi-step gateway instructions (e.g., verification sessions, message payload uploads).
added unittests to ensure that we parse & compute gas for message approval and message execution
Implemented a function that will scrape the Solana RPCs to build an accurate model of how much was paid in fees for every action