Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(market-pallet): deal settling #149

Conversation

cernicc
Copy link
Member

@cernicc cernicc commented Jul 19, 2024

Description

I wanted to test if it works. That is why it took some time to figure out which input params to use on the extrinnsics :D A deal should not be removed from the Proposals if the deal is still active. I've also added some logs.

Important points for reviewers

Before merging this please merge #143

Checklist

  • Are there important points that reviewers should know?
  • Make sure that you described what this change does.
  • Have you tested this solution?

@cernicc cernicc self-assigned this Jul 19, 2024
Copy link
Contributor

@th7nder th7nder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether we need that many logging in production code, but I agree with the fix. Should we add a unit test to check for not removing a deal from proposals as well?

@cernicc
Copy link
Member Author

cernicc commented Jul 19, 2024

I've added two tests for the on_finalize hook. Most of the logs are on the trace level. I think that trace level should not be enabled by default.

pallets/market/src/test.rs Outdated Show resolved Hide resolved
@cernicc cernicc requested a review from th7nder July 22, 2024 07:20
@jmg-duarte jmg-duarte merged commit 75442c8 into fix/136/storage-pallet-registering-a-provider-fails-with-conversionerror Jul 22, 2024
@jmg-duarte jmg-duarte deleted the fix/141/integration-tests-cannot-settle-a-deal branch July 22, 2024 15:52
@th7nder th7nder linked an issue Jul 22, 2024 that may be closed by this pull request
@th7nder th7nder added this to the Phase 1 milestone Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration Tests: cannot settle a deal
3 participants