-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(market-pallet): deal settling #149
fix(market-pallet): deal settling #149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure whether we need that many logging in production code, but I agree with the fix. Should we add a unit test to check for not removing a deal from proposals as well?
I've added two tests for the |
75442c8
into
fix/136/storage-pallet-registering-a-provider-fails-with-conversionerror
Description
I wanted to test if it works. That is why it took some time to figure out which input params to use on the extrinnsics :D A deal should not be removed from the Proposals if the deal is still active. I've also added some logs.
Important points for reviewers
Before merging this please merge #143
Checklist