Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: retrieval research rfc #623

Merged
merged 14 commits into from
Dec 17, 2024
Merged

docs: retrieval research rfc #623

merged 14 commits into from
Dec 17, 2024

Conversation

cernicc
Copy link
Member

@cernicc cernicc commented Dec 5, 2024

Description

Aggregated research about data retrieval

@cernicc cernicc self-assigned this Dec 5, 2024
RFCs/polka-retrieval.md Outdated Show resolved Hide resolved
RFCs/polka-retrieval.md Outdated Show resolved Hide resolved
RFCs/polka-retrieval.md Outdated Show resolved Hide resolved
RFCs/polka-retrieval.md Outdated Show resolved Hide resolved
RFCs/polka-retrieval.md Outdated Show resolved Hide resolved
RFCs/polka-retrieval.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RFC is lacking consistent writing

  • References should be together and have their own section
  • cli -> CLI, cid -> CID, p2p -> P2P, etc
  • Don't use emphasis markers and if you MUST use, use * instead of _, it's easier to read in plaintext format

RFCs/polka-retrieval.md Outdated Show resolved Hide resolved
RFCs/polka-retrieval.md Outdated Show resolved Hide resolved
RFCs/polka-retrieval.md Outdated Show resolved Hide resolved
RFCs/polka-retrieval.md Outdated Show resolved Hide resolved
RFCs/polka-retrieval.md Outdated Show resolved Hide resolved
RFCs/polka-retrieval.md Outdated Show resolved Hide resolved
@jmg-duarte jmg-duarte changed the title rfc: retrieval research docs: retrieval research rfc Dec 6, 2024
rfcs/002-retrieval-subsystem.md Outdated Show resolved Hide resolved
rfcs/002-retrieval-subsystem.md Outdated Show resolved Hide resolved
rfcs/002-retrieval-subsystem.md Outdated Show resolved Hide resolved
@jmg-duarte jmg-duarte added the rfc Request for Comments (RFC) label Dec 10, 2024
rfcs/002-retrieval-subsystem.md Outdated Show resolved Hide resolved
rfcs/002-retrieval-subsystem.md Outdated Show resolved Hide resolved
th7nder
th7nder previously approved these changes Dec 13, 2024
Copy link
Contributor

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This document should cover how the actual unsealed to file process happens, asides from the LID, how can we fetch the contents from inside the unsealed sector.

The suggestions are not "apply or reject", please review and apply changes to them if you wish

rfcs/002-data-retrieval.md Show resolved Hide resolved
rfcs/002-data-retrieval.md Outdated Show resolved Hide resolved
rfcs/002-data-retrieval.md Outdated Show resolved Hide resolved
rfcs/002-data-retrieval.md Outdated Show resolved Hide resolved
rfcs/002-data-retrieval.md Outdated Show resolved Hide resolved
rfcs/002-data-retrieval.md Outdated Show resolved Hide resolved
rfcs/002-data-retrieval.md Outdated Show resolved Hide resolved
rfcs/002-data-retrieval.md Outdated Show resolved Hide resolved
rfcs/002-data-retrieval.md Outdated Show resolved Hide resolved
rfcs/002-data-retrieval.md Outdated Show resolved Hide resolved
@cernicc cernicc requested a review from th7nder December 16, 2024 11:38
@cernicc cernicc requested a review from jmg-duarte December 16, 2024 11:38
jmg-duarte
jmg-duarte previously approved these changes Dec 16, 2024
Copy link
Contributor

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits

rfcs/002-data-retrieval.md Outdated Show resolved Hide resolved
rfcs/002-data-retrieval.md Outdated Show resolved Hide resolved
rfcs/002-data-retrieval.md Outdated Show resolved Hide resolved
rfcs/002-data-retrieval.md Outdated Show resolved Hide resolved
rfcs/002-data-retrieval.md Outdated Show resolved Hide resolved
rfcs/002-data-retrieval.md Outdated Show resolved Hide resolved
rfcs/002-data-retrieval.md Outdated Show resolved Hide resolved
rfcs/002-data-retrieval.md Outdated Show resolved Hide resolved
@cernicc cernicc added the ready for review Review is needed label Dec 17, 2024
@cernicc cernicc requested a review from jmg-duarte December 17, 2024 09:41
@cernicc cernicc enabled auto-merge (squash) December 17, 2024 09:41
@cernicc cernicc merged commit 95f04e2 into develop Dec 17, 2024
5 checks passed
@cernicc cernicc deleted the feat/polka-fetch branch December 17, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Review is needed rfc Request for Comments (RFC)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants