Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement settle_deal_payments extrinsic #90

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Implement settle_deal_payments extrinsic #90

merged 2 commits into from
Jun 28, 2024

Conversation

jmg-duarte
Copy link
Contributor

@jmg-duarte jmg-duarte commented Jun 20, 2024 •
edited
Loading

Description

Implement settle_deal_payments extrinsic

Important points for reviewers

This is based on #84, once that gets merged we can rebase this one

Checklist

  • Are there important points that reviewers should know?
    • If yes, which ones?
  • Make sure that you described what this change does.
  • If there are follow-ups, have you created issues for them?
    • If yes, which ones? / List them here
  • Have you tested this solution?
  • Were there any alternative implementations considered?
  • Did you document new (or modified) APIs?

@jmg-duarte jmg-duarte changed the title Feat/11/market pallet settle deals Implement settle_deal_payments extrinsic Jun 20, 2024
@th7nder th7nder linked an issue Jun 20, 2024 that may be closed by this pull request
[Tracking] Market Pallet Implementation #11
Closed
@jmg-duarte jmg-duarte force-pushed the feat/11/market-pallet-settle-deals branch from 016b2d1 to 425b559 Compare June 20, 2024 15:41
@jmg-duarte jmg-duarte mentioned this pull request Jun 20, 2024
Closed
@jmg-duarte jmg-duarte changed the base branch from develop to feat/11/market-pallet-publish-storage June 20, 2024 15:42
th7nder
th7nder reviewed Jun 21, 2024
View reviewed changes
Copy link
Contributor

@th7nder th7nder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good direction we're going towards :D

pallets/market/src/lib.rs Outdated Show resolved Hide resolved
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
@th7nder th7nder removed a link to an issue Jun 21, 2024
[Tracking] Market Pallet Implementation #11
Closed
@jmg-duarte jmg-duarte mentioned this pull request Jun 21, 2024
Merged
8 tasks
th7nder
th7nder reviewed Jun 21, 2024
View reviewed changes
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
@th7nder th7nder force-pushed the feat/11/market-pallet-publish-storage branch 2 times, most recently from 5673a3b to 5ffa9f4 Compare June 21, 2024 14:51
@jmg-duarte jmg-duarte requested a review from th7nder June 24, 2024 11:17
th7nder
th7nder requested changes Jun 24, 2024
View reviewed changes
pallets/market/src/lib.rs Show resolved Hide resolved
pallets/market/src/lib.rs Show resolved Hide resolved
pallets/market/src/lib.rs Show resolved Hide resolved
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
pallets/market/src/lib.rs Show resolved Hide resolved
@jmg-duarte jmg-duarte marked this pull request as ready for review June 24, 2024 16:43
th7nder
th7nder requested changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@th7nder th7nder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solid! let's test the burning and looks r2go.

pallets/market/src/lib.rs Outdated Show resolved Hide resolved
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
th7nder
th7nder previously approved these changes Jun 25, 2024
View reviewed changes
cernicc
cernicc previously approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@cernicc cernicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Base automatically changed from feat/11/market-pallet-publish-storage to feat/11/market-pallet-setup June 26, 2024 08:35
@jmg-duarte jmg-duarte changed the base branch from feat/11/market-pallet-setup to develop June 26, 2024 08:35
@jmg-duarte jmg-duarte dismissed stale reviews from cernicc and th7nder June 26, 2024 08:35

The base branch was changed.

@jmg-duarte jmg-duarte added ready for review Review is needed and removed ready for review Review is needed labels Jun 26, 2024
@jmg-duarte jmg-duarte requested review from cernicc and th7nder June 26, 2024 15:36
cernicc
cernicc previously approved these changes Jun 26, 2024
View reviewed changes
th7nder
th7nder requested changes Jun 26, 2024
View reviewed changes
Justfile Outdated Show resolved Hide resolved
pallets/market/src/lib.rs Show resolved Hide resolved
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
th7nder
th7nder previously approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@th7nder th7nder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 fuego infinito!

@th7nder th7nder mentioned this pull request Jun 27, 2024
Merged
8 tasks
@jmg-duarte jmg-duarte force-pushed the feat/11/market-pallet-settle-deals branch 2 times, most recently from 19b2c40 to 533194e Compare June 27, 2024 10:34
@th7nder th7nder mentioned this pull request Jun 27, 2024
Merged
8 tasks
@jmg-duarte jmg-duarte force-pushed the feat/11/market-pallet-settle-deals branch from 533194e to a0839cb Compare June 27, 2024 14:42
@jmg-duarte jmg-duarte requested review from th7nder and cernicc June 27, 2024 15:09
cernicc
cernicc previously approved these changes Jun 28, 2024
View reviewed changes
th7nder
th7nder requested changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@th7nder th7nder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry XD

pallets/market/src/lib.rs Outdated Show resolved Hide resolved
@jmg-duarte jmg-duarte force-pushed the feat/11/market-pallet-settle-deals branch from 5a702d0 to 37f0bf1 Compare June 28, 2024 12:37
@jmg-duarte jmg-duarte requested review from th7nder and cernicc June 28, 2024 12:39
th7nder
th7nder approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@th7nder th7nder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what took you so long...
just kidding, bloody amazing piece of work!

@jmg-duarte jmg-duarte added ready for review Review is needed and removed ready for review Review is needed labels Jun 28, 2024
@jmg-duarte jmg-duarte merged commit f134e1f into develop Jun 28, 2024
3 checks passed
@jmg-duarte jmg-duarte deleted the feat/11/market-pallet-settle-deals branch June 28, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cernicc cernicc cernicc approved these changes

@th7nder th7nder th7nder approved these changes

@serg-temchenko serg-temchenko Awaiting requested review from serg-temchenko

@aidan46 aidan46 Awaiting requested review from aidan46

Assignees

@jmg-duarte jmg-duarte

Labels
ready for review Review is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmg-duarte @cernicc @th7nder