Resurrect circular cushion collisions #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Under new definition, any ball with non-zero z-velocity is airborne - Airborne ball can still have zero z-velocity (like at apex of trajectory)
ekiefl
commented
Jan 5, 2025
Comment on lines
-206
to
-212
| v_z0 = rvw[1, 2] | ||
| r_z0 = rvw[0, 2] | ||
|
|
||
| if v_z0 < 0 and r_z0 == R: | ||
| # Ball is on the table with negative velocity. | ||
| return 0.0 | ||
|
|
There was a problem hiding this comment.
Does physics.get_airborne_time reliably return 0.0 in this scenario?
There was a problem hiding this comment.
Yes, this is tested in test_get_airborne_time
There was a problem hiding this comment.
final_ball_motion_state applied to han_2005 but not unrealistic
- Relative velocity is ill-defined for a ball not on the table, so don't calculate it at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.