Merge pull request #44 from pebie/patch-force-write

fix(force): prevent syncLogger reset canForceWrite
ekino · Jan 5, 2023 · aa89e8c · aa89e8c
2 parents d6a7dad + e8546f1
commit aa89e8c
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/src/definitions.ts b/src/definitions.ts
@@ -23,6 +23,7 @@ export interface Logger {
     warn: LogMethod
     error: LogMethod
     isLevelEnabled(level: string): boolean | undefined
+    canForceWrite?: boolean
 }
 
 export interface OutputAdapter {

diff --git a/src/index.ts b/src/index.ts
@@ -280,7 +280,7 @@ export const syncLogger = (logger: Logger, namespace: string, canForceWrite?: bo
 
         logger.isLevelEnabled = (level) => enabledLevels[level]
     }
-
+    logger.canForceWrite = canForceWrite
     return logger
 }
 
@@ -290,7 +290,7 @@ export const syncLogger = (logger: Logger, namespace: string, canForceWrite?: bo
  */
 export const syncLoggers = () => {
     for (const [namespace, logger] of Object.entries(internals.loggers)) {
-        syncLogger(logger, namespace)
+        syncLogger(logger, namespace, logger.canForceWrite)
     }
 }
 

diff --git a/test/logger.js b/test/logger.js
@@ -84,6 +84,19 @@ test('A logger instance should log if instance can forceWrite and forceLogging i
     logger.write.restore()
 })
 
+test('setLevel and setNamespace should not reset canForceWrite', (t) => {
+    const log = logger.createLogger('test', true)
+    logger.setNamespaces('*')
+    logger.setLevel('info')
+    const spy = sinon.spy(logger, 'write')
+
+    log.debug(null, {}, true)
+
+    t.is(spy.callCount, 1)
+
+    logger.write.restore()
+})
+
 test("A logger instance shouldn't log if namespace is not enabled", (t) => {
     logger.setNamespaces('test:*')