Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript|ci): convert js to ts #29

Closed
wants to merge 1 commit into from
Closed

Conversation

tduyng
Copy link
Contributor

@tduyng tduyng commented Oct 1, 2021

Closes ~26
Closes ~27
Closes ~28

Change:

  • Convert js to ts
  • Refactor methods and tests
  • Replace travis CI with Github actions
  • Using jest for testing (instead of ava & sinon)
  • Using coveralls for github actions
  • Add test check for all LTS version nodejs (12.x, 14.x, 16.x)
  • Change structure of project, push the code ts files in the folder src

TODO:

  • Make unit test for each method (actually does not) -> to close ~25
  • To fix issue of test for method pretty in /test/output_adapter.test.ts. Github actions is not working for comparing string with color
  • Improve some types
  • Remove lodash

@tduyng tduyng force-pushed the master branch 3 times, most recently from 7c0f9e8 to 6e28df4 Compare October 1, 2021 07:36
@fthouraud
Copy link
Contributor

Hi 👋

Thank you for your contribution. Could you consider opening a PR for each issue separately, please?

To migrate to TS, we could benefit from extended coverage (expressed in #25). That way, it would be easier to avoid errors.

@fthouraud
Copy link
Contributor

By the way, I just saw you replaced AVA and Sinon with Jest. Why do you think it is an improvement?

@tduyng
Copy link
Contributor Author

tduyng commented Oct 23, 2021

Hi Fabien, thanks for your reply.
I'll try to separate them soon. And for your question: "Why do you think it is an improvement?": It juste the problem of my vocabulary. I change the word "Improvement" to "Change". By the way, I will close this PR and try to create a PR for each issue.

@tduyng tduyng closed this Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants