New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace TravisCI to GithubCI #30

Closed

tduyng wants to merge 2 commits into ekino:master from tduyng:OAC-0002-github-ci

Contributor

tduyng commented Nov 29, 2021 •

edited

Loading

Close #26 & Close #27
Something I did in this PR:

Migrate yarn to v2 + add yarn plugin interactive (I help us to upgrade the dependencies easier).
Replace TravisCI with Github Action

I have trouble with:

Coveralls Github Action. nyc does not create the coverage folder. It will be failed when I run with Github Action. I try to run with jest, it works very well.
I found a problem for compare string with the format of colour. You can find it in the file: test/output_adapters.js: line114 & 144. It works on local but not with Github CI. I don't find any solution for this moment.

I'am very appreciate for any help to solve those problems.

(I also create a PR using jest and add coveralls in github action)

tduyng added 2 commits

November 29, 2021 09:02


          chore(yarn): migrate to yarn v2

2185ed2


          ci(githubAction): convert travisCI to github action

898065e

pebie closed this

tduyng deleted the OAC-0002-github-ci branch

July 27, 2022 10:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet