Increase logging of testcontainer #2468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the test to account for a product check span, restricting the parent span selection to the one associated with 'request' action. This ensures the test accurately identifies the correct parent span to validate against expected behaviors.
Introduced a new CosmosDbFact attribute to replace AzureCredentialsFact for CosmosDb tests. This attribute includes checks for Azure credentials and skips tests on CI environments where CosmosDb tests are temporarily disabled. All existing CosmosDb tests have been updated to use CosmosDbFact.
estolfo
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also updates TestContainers to a version that's passing the cancellation token to SemaphoreSlim.
We now also forcefully break out if disposing the container takes longer then 2 minutes.