Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tf: fix benchmarking standalone apm to use x86_64 AMI by default #15654

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

carsonip
Copy link
Member

Motivation/summary

Fix a regression where benchmarking standalone apm server does not find a matching x86_64 AMI for c6i instance types.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

Fixes #15604

@carsonip carsonip requested a review from a team as a code owner February 10, 2025 19:11
Copy link
Contributor

mergify bot commented Feb 10, 2025

This pull request does not have a backport label. Could you fix it @carsonip? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-9./d is the label to automatically backport to the 9./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@carsonip carsonip added the backport-9.0 Automated backport to the 9.0 branch label Feb 10, 2025
@carsonip
Copy link
Member Author

If https://github.com/elastic/apm-server/actions/runs/13248610640 passes, this PR should be good to merge.

@carsonip
Copy link
Member Author

terraform apply works. PR is good to merge.

@carsonip carsonip enabled auto-merge (squash) February 10, 2025 19:20
@carsonip carsonip merged commit 405a8f7 into main Feb 10, 2025
14 checks passed
@carsonip carsonip deleted the tf-standalone-apm-ami branch February 10, 2025 19:24
mergify bot pushed a commit that referenced this pull request Feb 10, 2025
)

Fix a regression where benchmarking standalone apm server does not find a matching x86_64 AMI for c6i instance types.

(cherry picked from commit 405a8f7)
mergify bot added a commit that referenced this pull request Feb 10, 2025
) (#15658)

Fix a regression where benchmarking standalone apm server does not find a matching x86_64 AMI for c6i instance types.

(cherry picked from commit 405a8f7)

Co-authored-by: Carson Ip <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-9.0 Automated backport to the 9.0 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tf: standalone apm server aws_os not exist
2 participants