Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix system module with both filesets enabled #41381

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix system module with both filesets enabled #41381

wants to merge 6 commits into from
+220 −67

Commits on Oct 23, 2024

  1. Fix system module with both filesets enables 

    The system module did not define an ID at the root of the config, that
made the V2 input loader only start the first journald input it saw
because they both ended up with the same identifier (type, ID and
path). This is fixed by defining an ID at the root of the
configuration templates.

The journald input now also adds the `input_id` key to its loggers
and a non-fatal error is now logged at debug level.

The system-logs input is now marked as experimental instead of stable.
    @belimawr
    belimawr committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    4116a25 View commit details
    Browse the repository at this point in the history

  2. Fix lint warnings 

    Fix lint warnings by moving toJournalConfig to input_linux.go
    @belimawr
    belimawr committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    68a1c2b View commit details
    Browse the repository at this point in the history

  3. Add tests

    @belimawr
    belimawr committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    5d4ab5f View commit details
    Browse the repository at this point in the history

  4. Fix test failure message

    @belimawr
    belimawr committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    dd8e243 View commit details
    Browse the repository at this point in the history

  5. Implement review suggestions

    @belimawr
    belimawr committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    e517e18 View commit details
    Browse the repository at this point in the history

  6. Fix TestSystemLogsCanUseLogInput and run it on all OSes 

    Fix TestSystemLogsCanUseLogInput and move it to a file without the
linux build constraint so it can run on all OSes supported by the
system integration.
    @belimawr
    belimawr committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    d25f496 View commit details
    Browse the repository at this point in the history