Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rule Tuning] Adjusting Verbiage for AWS EC2 Instance Connect SSH Public Key Uploaded #4334

Merged
merged 5 commits into from
Jan 15, 2025

Conversation

terrancedejesus
Copy link
Contributor

@terrancedejesus terrancedejesus commented Jan 6, 2025

Pull Request

Issue link(s):

Summary - What I changed

Adjusted verbiage for this rule. Previously we only stated that this covered SSH key uploads to an EC2 instance. However, it is also an indicator fr EC2 Instance Connect connections as well via aws ec2-instance-connect ssh... command. This command, when executed, will automatically send the same API call as the aws ec2-instance-connect send-ssh-public-key... command would prior to establishing the SSH connection. There is no CloudTrail event action recorded for the aws ec2-instance-connect ssh..., therefore this rule is the only indicator for such activity.

Updated MITRE ATT&CK and description. Note, volume of alerts is relatively low for the past 90 days, no additional tuning necessary for detection logic.

How To Test

Checklist

  • Added a label for the type of pr: bug, enhancement, schema, maintenance, Rule: New, Rule: Deprecation, Rule: Tuning, Hunt: New, or Hunt: Tuning so guidelines can be generated
  • Added the meta:rapid-merge label if planning to merge within 24 hours
  • Secret and sensitive material has been managed correctly
  • Automated testing was updated or added to match the most common scenarios
  • Documentation and comments were added for features that require explanation

Contributor checklist

@terrancedejesus terrancedejesus added documentation Improvements or additions to documentation Rule: Tuning tweaking or tuning an existing rule labels Jan 6, 2025
@terrancedejesus terrancedejesus self-assigned this Jan 6, 2025
@protectionsmachine
Copy link
Collaborator

Rule: Tuning - Guidelines

These guidelines serve as a reminder set of considerations when tuning an existing rule.

Documentation and Context

  • Detailed description of the suggested changes.
  • Provide example JSON data or screenshots.
  • Provide evidence of reducing benign events mistakenly identified as threats (False Positives).
  • Provide evidence of enhancing detection of true threats that were previously missed (False Negatives).
  • Provide evidence of optimizing resource consumption and execution time of detection rules (Performance).
  • Provide evidence of specific environment factors influencing customized rule tuning (Contextual Tuning).
  • Provide evidence of improvements made by modifying sensitivity by changing alert triggering thresholds (Threshold Adjustments).
  • Provide evidence of refining rules to better detect deviations from typical behavior (Behavioral Tuning).
  • Provide evidence of improvements of adjusting rules based on time-based patterns (Temporal Tuning).
  • Provide reasoning of adjusting priority or severity levels of alerts (Severity Tuning).
  • Provide evidence of improving quality integrity of our data used by detection rules (Data Quality).
  • Ensure the tuning includes necessary updates to the release documentation and versioning.

Rule Metadata Checks

  • updated_date matches the date of tuning PR merged.
  • min_stack_version should support the widest stack versions.
  • name and description should be descriptive and not include typos.
  • query should be inclusive, not overly exclusive. Review to ensure the original intent of the rule is maintained.

Testing and Validation

  • Validate that the tuned rule's performance is satisfactory and does not negatively impact the stack.
  • Ensure that the tuned rule has a low false positive rate.

@botelastic botelastic bot added Domain: Cloud Integration: AWS AWS related rules labels Jan 6, 2025
@terrancedejesus terrancedejesus merged commit f8312cc into main Jan 15, 2025
9 checks passed
@terrancedejesus terrancedejesus deleted the rule-tuning-aws-ec2-instance-connect-verbiage branch January 15, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport: auto documentation Improvements or additions to documentation Domain: Cloud Integration: AWS AWS related rules Rule: Tuning tweaking or tuning an existing rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants