Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few more repositories to the Buildkite job rollout - see comm email about it.
Note to reviewers (ideally doc point persons):
1. Validate the build avoidance logic (if applicable)
The Buildkite PR bot has some build avoidance logic in place. Some repositories are configured to have the docs PR job for any changes in the repo. Other are configured for changes in the "docs" folder only.. I tried to follow the docs script build avoidance logic to determine how the repo should be configured, but you need to validate that this is actually the case.
Repos configured to trigger PR on
every
changesRepos configured to trigger PR on changes in the
docs
folder only2. Setup or update your GH action
As mentioned in the comm email, you can setup a GitHub action that posts a comment with various links to validate the doc
Here's an example setup you can copy in your repo.
3. Assess if you anticipate potential conflicts with other Buildkite pipelines in your repository
The docs PR job leverages the Buildkite PR bot. Before merging this PR, I will setup a webhook in your repository (following the instructions here). The config used for the PR job lives in the docs repo in the ./buildkite/pull-requests.org-wide.json file. There should not be any conflicts with your current jobs, but I like to be overly explicit with it.
4. What to expect once this is setup?
The Buildkite PR jobs are non-blocking at this time - but we need your help validating that they produce the same results than in Jenkins - see comm.
The below options are supported to trigger the docs builds:
CC - @robbavey @dliappis on the new Buildkite jobs for logstash