Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicates from conf.yaml #2861

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Remove duplicates from conf.yaml #2861

merged 3 commits into from
Dec 12, 2023

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Dec 11, 2023 •
edited
Loading

This PR updates the conf.yaml to remove two books that were appearing in multiple sections (and thus potentially causing build problems). It also updates the conf.yaml such that the Beats books are all grouped together.

@github-actions GitHub Actions
Copy link

A documentation preview will be available soon.
Help us out by validating the Buildkite preview and reporting issues here.

@lcawl lcawl marked this pull request as ready for review December 12, 2023 00:00
bmorelli25
bmorelli25 approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo!

kilfoyle
kilfoyle approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🦕
Thanks!!!

@lcawl lcawl merged commit 1c8f37f into elastic:master Dec 12, 2023
4 checks passed
@lcawl lcawl deleted the docs-dups branch December 12, 2023 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilfoyle kilfoyle kilfoyle approved these changes

@bmorelli25 bmorelli25 bmorelli25 approved these changes

@colleenmcginnis colleenmcginnis Awaiting requested review from colleenmcginnis

@leemthompo leemthompo Awaiting requested review from leemthompo

@scottybollinger scottybollinger Awaiting requested review from scottybollinger scottybollinger was automatically assigned from elastic/docs-engineering

@glitteringkatie glitteringkatie Awaiting requested review from glitteringkatie glitteringkatie was automatically assigned from elastic/docs-engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lcawl @bmorelli25 @kilfoyle