Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS #2868

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Update CODEOWNERS #2868

merged 2 commits into from
Dec 13, 2023

Conversation

glitteringkatie
Copy link
Contributor

Reduce noise for docs-engineering, add us when you need us!

Reduce noise for docs-engineering, add us when you need us!
Copy link

A documentation preview will be available soon.

Help us out by validating the Buildkite preview and reporting issues here.
Please also be sure to double check all images to ensure they are correct in the preview.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

bmorelli25
bmorelli25 previously approved these changes Dec 13, 2023
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this. Maybe the best solution is to create a new team (I know, another new team) that has all of the codeowners for this repo listed out. We could then use the GitHub team assignment rules to only ping x number of people per PR. That would reduce noise for all.

I'm open to other ideas as well.

@leemthompo
Copy link
Contributor

@bmorelli25 I'm not sure why I'm a code owner here either TBH 😄

@bmorelli25
Copy link
Member

bmorelli25 commented Dec 13, 2023

@leemthompo codeowners were added in #2827. Here are the details without pinging everyone:

  • @\elastic/docs-release-team: This team includes, @\bmorelli25, @\KOTungseth, @\abdonpijpelink, @\joepeeples, and @\lcawl
  • The writer who knows the most about how the classic doc system works: @\colleenmcginnis
  • The two highest contributors (based on number of commits in the past year) to this repo outside of the above folks: @\kilfoyle and @\leemthompo

I'd like to keep you as a codeowner due to your commit history in this repo and your time zone. The new round-robin review format introduced in c2928a3 should greatly reduce the noise you experience. Also, the docs migration is nearly complete, which means this repo will go back to being much less active than it currently is.

@glitteringkatie
Copy link
Contributor Author

Congrats @leemthompo for being our docs MVP! Your reward is 100000 code reviews 🎉

@leemthompo
Copy link
Contributor

@bmorelli25 thanks for the context, I missed that broadcast somehow 😃

@bmorelli25 bmorelli25 merged commit f491c40 into master Dec 13, 2023
5 checks passed
@bmorelli25 bmorelli25 deleted the glitteringkatie-patch-1 branch December 13, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants