Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECS current to 8.11 #2893

Merged
merged 3 commits into from
Jan 22, 2024
Merged

ECS current to 8.11 #2893

merged 3 commits into from
Jan 22, 2024

Conversation

kgeller
Copy link
Contributor

@kgeller kgeller commented Jan 12, 2024

The team will not be releasing an ECS 8.12 while we decide how to approach releases of ECS going forward

I also cleared out some of the older versions from the live options.


Relates https://github.com/elastic/security-team/issues/8182

@kgeller kgeller requested a review from a team as a code owner January 12, 2024 18:29
Copy link

A documentation preview will be available soon.

Help us out by validating the Buildkite preview and reporting issues here.
Please also be sure to double check all images to ensure they are correct in the preview.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

kilfoyle
kilfoyle previously approved these changes Jan 12, 2024
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
As long as this passes CI checks it should be good to go. 🚀

@bmorelli25
Copy link
Member

I'm not convinced this will pass link-checking, but we'll see. After this is merged, we'll need to merge master into @abdonpijpelink's 8.12 PR: #2862

@kgeller
Copy link
Contributor Author

kgeller commented Jan 12, 2024

@bmorelli25 Looks like you called it not passing CI. Does that mean it's not possible to omit an ECS version?

@bmorelli25
Copy link
Member

It doesn't mean it's not possible. It just means it's going to be a much more complex process than this PR. A lot of how we move forward depends on what the future of the ECS release process looks like. Right now, we map ECS docs 1:1 to Stack docs. If that's changing, we'll need to rethink how we link to ECS documentation. I would set some time up to chat with your technical writer about potential next steps.

@kgeller
Copy link
Contributor Author

kgeller commented Jan 12, 2024

A lot of how we move forward depends on what the future of the ECS release process looks like. Right now, we map ECS docs 1:1 to Stack docs. If that's changing, we'll need to rethink how we link to ECS documentation.

Makes sense, and that is still being worked out.

If we hold off on cleaning up the selectors for now, is it possible to keep ECS current at 8.11 for the time being?

@bmorelli25
Copy link
Member

Hmm. That could potentially work. Wanna edit this PR and see what the checks say? That's the best way to test.

@kgeller kgeller changed the title Removing 8.12 from ECS selectors ECS current to 8.11 Jan 16, 2024
@kgeller
Copy link
Contributor Author

kgeller commented Jan 18, 2024

@bmorelli25 looks like CI is happy with ecs current : 8.11

@bmorelli25 bmorelli25 merged commit 15e318c into elastic:master Jan 22, 2024
4 checks passed
@kgeller kgeller deleted the remove-ecs-8.12 branch January 22, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants