Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set 1.x as current for APM agent iOS docs #2905

Merged
merged 6 commits into from
Jan 25, 2024
Merged

Set 1.x as current for APM agent iOS docs #2905

merged 6 commits into from
Jan 25, 2024

Conversation

bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented Jan 25, 2024 •
edited
Loading

@bmorelli25 bmorelli25 requested a review from a team as a code owner January 25, 2024 16:05
@github-actions GitHub Actions
Copy link

A documentation preview will be available soon.

Help us out by validating the Buildkite preview and reporting issues here.
Please also be sure to double check all images to ensure they are correct in the preview.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

LikeTheSalad
LikeTheSalad previously approved these changes Jan 25, 2024
View reviewed changes
@bmorelli25 bmorelli25 enabled auto-merge (squash) January 25, 2024 16:14
@colleenmcginnis
Copy link
Contributor

@bmorelli25 should we also updates shared/versions/stack/master.asciidoc and shared/versions/stack/8.12.asciidoc?

colleenmcginnis
colleenmcginnis approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍏

@bmorelli25 bmorelli25 merged commit d0bf143 into master Jan 25, 2024
5 checks passed
@bmorelli25 bmorelli25 deleted the bmorelli25-patch-2 branch January 25, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colleenmcginnis colleenmcginnis colleenmcginnis approved these changes

@LikeTheSalad LikeTheSalad LikeTheSalad left review comments

@lcawl lcawl Awaiting requested review from lcawl lcawl is a code owner automatically assigned from elastic/docs-repo-owners

@leemthompo leemthompo Awaiting requested review from leemthompo leemthompo is a code owner automatically assigned from elastic/docs-repo-owners

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmorelli25 @colleenmcginnis @LikeTheSalad