-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that _all_ legacy books contain noindex: 1
#3005
Ensure that _all_ legacy books contain noindex: 1
#3005
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The interesting thing is that some of these (36) books don't show up in the legacy section on elastic.co/guide (28). Kibana 사용자 가이드
is one example. Either way, 🐦
This one shows up on a subsection (i made up this term) landing page: https://www.elastic.co/guide/kr/index.html |
run docs-build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 2. Seems like it's reasonable to remove the "live" list from the functionbeat and siem docs too
👍 I needed to push another commit to trigger the tests to run anyway, so I removed the remaining |
Makes sure that all versions of all legacy books are not being indexed. (Not sure if we should be indexing Functionbeat and SIEM docs as they still have live versions...)
cc @lcawl @KOTungseth @katymcdougall