Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that _all_ legacy books contain noindex: 1 #3005

Merged

Conversation

colleenmcginnis
Copy link
Contributor

Makes sure that all versions of all legacy books are not being indexed. (Not sure if we should be indexing Functionbeat and SIEM docs as they still have live versions...)

cc @lcawl @KOTungseth @katymcdougall

Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@colleenmcginnis colleenmcginnis self-assigned this May 22, 2024
bmorelli25
bmorelli25 previously approved these changes May 22, 2024
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The interesting thing is that some of these (36) books don't show up in the legacy section on elastic.co/guide (28). Kibana 사용자 가이드 is one example. Either way, 🐦

@colleenmcginnis
Copy link
Contributor Author

colleenmcginnis commented May 22, 2024

Kibana 사용자 가이드 is one example

This one shows up on a subsection (i made up this term) landing page: https://www.elastic.co/guide/kr/index.html

@colleenmcginnis
Copy link
Contributor Author

run docs-build

lcawl
lcawl previously approved these changes May 22, 2024
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 2. Seems like it's reasonable to remove the "live" list from the functionbeat and siem docs too

@colleenmcginnis colleenmcginnis dismissed stale reviews from lcawl and bmorelli25 via 94d1dee May 22, 2024 16:46
@colleenmcginnis
Copy link
Contributor Author

Seems like it's reasonable to remove the "live" list from the functionbeat and siem docs too

👍 I needed to push another commit to trigger the tests to run anyway, so I removed the remaining live properties in legacy books.

@colleenmcginnis colleenmcginnis merged commit dcd9709 into elastic:master May 22, 2024
3 checks passed
@colleenmcginnis colleenmcginnis deleted the stop-indexing-all-legacy branch May 22, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants