Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(all): only build docs if there's a doc change #3067

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

kruskall
Copy link
Member

extend the check to all remaining repositories

extend the check to all remaining repositories
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@bmorelli25
Copy link
Member

This is incredible

@bmorelli25
Copy link
Member

bmorelli25 commented Oct 21, 2024

@elastic/docs-build-guild any reservations or thoughts before I merge this? This PR adds on to #3066.

This PR enables all documentation repositories (except Kibana) to exist the documentation build early if there are no doc-related changes. This will save time and money. For all enabled repos, we fetch the latest changes from the target branch of the pull request and check for changes in specified files and directories with git diff.

@bmorelli25 bmorelli25 requested a review from a team October 21, 2024 16:24
@bmorelli25 bmorelli25 merged commit 05da2ba into elastic:master Oct 21, 2024
3 checks passed
@kruskall kruskall deleted the feat/lazy-build-all branch October 21, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants