Updated to NET8 since NET6 is obsolete #469
Open
+54
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snakefoot
force-pushed
the
net8
branch
4 times, most recently
from
f0b6f25 to
9e6a84c
Compare
snakefoot
force-pushed
the
net8
branch
2 times, most recently
from
c9d42a4 to
16dee0c
Compare
|
@Mpdreamz Possible to re-trigger the build one more time? |
Mpdreamz
previously approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Excellent work as always @snakefoot ! Sorry it took a while on my end to review and get this in.
flobernd
previously approved these changes
Jan 29, 2025
| @@ -14,7 +14,9 @@ runs: | |||
| # Install .NET version as mandated by global.json | |||
| - uses: actions/setup-dotnet@v4 | |||
| with: | |||
| global-json-file: global.json | |||
There was a problem hiding this comment.
What's the reason for this change? Do we need both, net6 and net8 installed?
There was a problem hiding this comment.
This was needed for nupkg-validator but the bump to 0.5.0 should have fixed this 🤞 will revert this to verify.
Starting with .NET 9.0 the SDK check on dotnet tools is relaxed which is great.
flobernd
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.