-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(refactor): refactor chart specific selectors out of state #2613
Open
walterra
wants to merge
20
commits into
elastic:main
Choose a base branch
from
walterra:redux-internal-selectors
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,271
−1,352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbeb5cd
to
c31b452
Compare
7 tasks
0328248
to
d03b5fc
Compare
… upcoming eslint rule.
d477177
to
db0af57
Compare
✅ Successful Deployment (build#4595) - b875fde |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors chart specific selectors out of redux state.
Details
The selectors and renderer in
internalChartState
are functions which means they are not suitable to be part of redux state. This PR removesinternalChartState
from the redux state. An unfortunate effect of doing this is that it causes quite some circular dependency problems because of two-way imports between the mainchart_state
code and chart specific code. To solve this, the following changes have been done:internalChartState
included both a renderer and selectors. Part of the circular dependency problems was that the renderer included React components, which use the selectors, which make use ofgetInternalChartState
, which again includes the renderer!chartRenderer
will now only be called fromchart_container.tsx
so it's no longer imported anywhere from the mainchart_state
.chartSelectors
use mostly the same interface asinternalChartState
previously. However, instead of importing all code backwards from individual charts back to mainchart_state
, inchart_state
we now have just a typed chart selector registry. That means we are no longer importing selectors code from individual charts back to mainchart_state
. Instead, incomponents/chart.tsx
the registry is populated with selectors from individual charts.InternalChartState
implemented a class. It is now refactored into a factory that returns default implementations which can be overridden by individual charts. This means the defaults are now part of mainchart_state
and don't need to be replicated by every individual chart. This more or less flips around the implementation of defaults which should reduce some circular dependency risk too. It also reduces the risk of diverging default implementations.Issues
Part of #2078 and #2615.
Checklist
:xy
,:partition
):interactions
,:axis
)closes #123
,fixes #123
)packages/charts/src/index.ts
light
anddark
themes