fix(slack notifications): correct the if-logic for skipping some noti…

…fications (#539)
elastic · Jan 14, 2025 · 277a724 · 277a724
1 parent c853fe9
commit 277a724
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/.github/workflows/slack.yml b/.github/workflows/slack.yml
@@ -27,9 +27,11 @@ jobs:
     # Skip notification if:
     # - dependabot or renovate PRs, too noisy
     # - draft PRs
-    if: ${{ !(github.event.action == 'opened' && github.event.pull_request.draft) ||
-      github.event.pull_request.user.login != 'dependabot[bot]' ||
-      github.event.pull_request.user.login != 'elastic-renovate-prod[bot]' }}
+    if: ${{ !(
+        (github.event.action == 'opened' && github.event.pull_request.draft) ||
+        github.event.pull_request.user.login == 'dependabot[bot]' ||
+        github.event.pull_request.user.login == 'elastic-renovate-prod[bot]'
+      ) }}
     runs-on: ubuntu-24.04
     steps:
       - name: Prepare Slack message
@@ -117,7 +119,6 @@ jobs:
             f.write("payload={}".format(json.dumps(payload)))
 
       - name: Post Slack message
-        if: ${{ steps.prepare.outputs.payload }}
         uses: slackapi/[email protected]
         with:
           method: chat.postMessage