-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update geoip databases to include data about documentation ranges #2450
base: main
Are you sure you want to change the base?
Conversation
test integrations |
Created or updated PR in integrations repository to test this version. Check elastic/integrations#12962 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried to use "real" cities here in the new entries. And for that, I got the data about them (geo codes or latitute/longitude values) using https://www.geonames.org/
The assignation of this ranges to those cities is faked and it is just for testing purposes in elastic-package
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you see any issue of using that data here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test integrations |
Created or updated PR in integrations repository to test this version. Check elastic/integrations#12962 |
test integrations |
Created or updated PR in integrations repository to test this version. Check elastic/integrations#12983 |
Include documentation about these GeoLite2 databases and how they should be generated.
88211de
to
906b3a6
Compare
💚 Build Succeeded
History
cc @mrodm |
Closes #2414
Follows #2408
This PR includes new GeoIP databases including some entries for the documentation prefixes.
Added entries for the following address blocks for documentation in the GeoLite2 JSON files:
I've tried to use other "real" cities here (Las Vegas, Amsterdam and Madrid) as well as Greenwich (as mentioned in this blog post), and get the data about them using https://www.geonames.org/
This data set in those JSON files is faked just for testing purposes in elastic-package. This could affect system and pipeline tests.
Data added to the databases can be reviewed in this commit: 906b3a6
Moreover, some tests have been added to the
isAllowedIPValue
function as well as it has been used an IP of the documentation range in the test packageapache
.Author's checklist
How to test this PR locally