Add SystemTextJsonSerializer.SupportsFastPath method
#154
Conversation
| /// </para> | ||
| /// <para> | ||
| /// In some cases, when the concrete <see cref="SystemTextJsonSerializer"/> based serializer implementation overrides one or more of | ||
| /// the named methods, the default fast-path behavior might be undesired. The <see cref="SupportsFastPath"/> method can be used to |
There was a problem hiding this comment.
Can you expand why the fast path might be undesirable?
I grasp the use case for not prefering the fast path.
There was a problem hiding this comment.
If the user overrides one of these methods, there is probably a reason for doing so.
Like mentioned, fast path will bypass the Deserialize/Serialize method invocation, which in conclusion will as well bypass execution of the user code (which is why fast path is undesirable in these cases, otherwise there wouldn't have been a good reason for overriding Deserialize/Serialize in the first place).
Is that unclear from the doc comment?
There was a problem hiding this comment.
Comments make more sense in the morning then late at night :)
There was a problem hiding this comment.
True :D Thanks for the review! I will try to rephrase it a bit before merging to make it more clear.
The
DefaultRequestResponseSerializerimplementation in the Elasticsearch client (based onSystemTextJsonSerializer) overrides theDeserialize/Serializemethods to drive special serialization, if the type implementsIStreamSerializable. This is done to support e.g. NDJSON request/response bodies.Fast-path (de-)serialization currently incorrectly bypasses this special handling.
This PR provides a way to selectively disable the fast-path (de-)serialization for specific types.