Full code for esql article #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swallez
reviewed
Apr 22, 2024
There was a problem hiding this comment.
Nice example!
Considering that it's a single class, it would probably make sense to move it to java-client/src/main/test/co/elastic/clients/documentation/api_conventions so that we can reuse it in ES|QL-related docs.
Or at least make it a child of the root project, so that we don't have a duplicate Gradle installation and so that it can be compiled as part of the regular build process.
|
|
||
| boolean hasNext = true; | ||
|
|
||
| while (hasNext) { |
There was a problem hiding this comment.
Nit: use the more common while(it.hasNext()) construct?
There was a problem hiding this comment.
it.hasNext() throws an exception if lines are malformed, I wanted to keep everything into the loop so malformed lines can be ignored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.