Using matching docker container server version in unit tests #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swallez
reviewed
Nov 13, 2024
java-client/src/test/java/co/elastic/clients/elasticsearch/ElasticsearchTestServer.java
Outdated
Show resolved
Hide resolved
swallez
approved these changes
Nov 14, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
* unit test container version latest * fetching version info from artifacts api * using io utils also for writing * checkstyle
github-actions bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
* unit test container version latest * fetching version info from artifacts api * using io utils also for writing * checkstyle
github-actions bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
* unit test container version latest * fetching version info from artifacts api * using io utils also for writing * checkstyle
This was referenced Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugins unit test will be broken in the main branch, because there's no stable 9 release and the client will send 9.0.0 headers, meaning it will fail with a header exception.