-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Updates Buildkite configuration #2254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! I had it on my "as I have time" list to start moving Python over to Buildkite, but you beat me to it.
8816f94
to
6d60fca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still looks great to me.
ENV PATH="${PATH}:/var/lib/elastic/.local/bin" | ||
|
||
# Create user | ||
RUN groupadd --system -g ${BUILDER_GID} ${BUILDER_GROUP} \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we established that we don't need to do group/user ID stuff in these containers any more, as that was a requirement for DRA, and Python isn't part of DRA any more. @picandocodigo correct me if I'm misremembering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right 👍
I just double-checked the output of job runs on Buildkite and they're getting pretty similar pass/fail rate as on Jenkins for the integration test suite. Removing unused stuff from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM. I'm considering merging and and address @JoshMock great comments in a future pull request.
This can also get a catalog-info.yaml file. https://github.com/elastic/catalog-info/pull/563 was merged earlier today. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.11 8.11
# Navigate to the new working tree
cd .worktrees/backport-8.11
# Create a new branch
git switch --create backport-2254-to-8.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 24a4583858c032d8ddafd25e6658308a789b4108
# Push it to GitHub
git push --set-upstream origin backport-2254-to-8.11
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.11 Then, create a pull request where the |
* [CI] Updates Buildkite configuration * Copy updated test certificates to .buildkite * Stop testing 3.6 as in Jenkins * Simplify Dockerfile by relying more on nox --------- Co-authored-by: Quentin Pradet <[email protected]> Co-authored-by: Josh Mock <[email protected]> (cherry picked from commit 24a4583)
8.11 was forked after that pull request. |
* [CI] Updates Buildkite configuration (#2254) * [CI] Updates Buildkite configuration * Copy updated test certificates to .buildkite * Stop testing 3.6 as in Jenkins * Simplify Dockerfile by relying more on nox --------- Co-authored-by: Quentin Pradet <[email protected]> Co-authored-by: Josh Mock <[email protected]> (cherry picked from commit 24a4583) * Remove .ci directory * Remove more references to .ci * Fix Assemble action * Drop unified release workflow * Switch to pytest_asyncio.fixture This is required now that strict mode is the default. * Fix test_errors_are_reported_correctly --------- Co-authored-by: Fernando Briano <[email protected]> Co-authored-by: Quentin Pradet <[email protected]>
Updates configuration to run integration tests on Buildkite.