Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated ML path and options #3871

Merged
merged 2 commits into from
Mar 5, 2025
Merged

Conversation

davidkyle
Copy link
Member

The path and options were deprecated in 8 for removal in 9. The corresponding Elasticsearch change is in elastic/elasticsearch#124019

@l-trotta l-trotta requested review from a team as code owners March 5, 2025 09:37
Copy link
Contributor

@l-trotta l-trotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidkyle I updated the typescript spec accordingly

Copy link
Contributor

github-actions bot commented Mar 5, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ml.get_trained_models 🔴 36/37 37/37
ml.infer_trained_model 🟢 10/10 10/10

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

@valeriy42 valeriy42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l-trotta l-trotta merged commit 1a9b6ac into main Mar 5, 2025
8 checks passed
@l-trotta l-trotta deleted the remove-deprecated-ml-options branch March 5, 2025 15:19
github-actions bot pushed a commit that referenced this pull request Mar 5, 2025
* Remove old path an options

* removed deprecated options from ts spec

---------

Co-authored-by: Laura Trotta <[email protected]>
(cherry picked from commit 1a9b6ac)
l-trotta pushed a commit that referenced this pull request Mar 5, 2025
* Remove old path an options

* removed deprecated options from ts spec

---------

Co-authored-by: Laura Trotta <[email protected]>
(cherry picked from commit 1a9b6ac)

Co-authored-by: David Kyle <[email protected]>
@davidkyle
Copy link
Member Author

@davidkyle I updated the typescript spec accordingly

Thank you @l-trotta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants