Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support subobjects: auto #3877

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Support subobjects: auto #3877

merged 1 commit into from
Mar 5, 2025

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Mar 5, 2025

This fixes validation for cluster.put_component_template.

Copy link
Member

@flobernd flobernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -59,3 +59,16 @@ export class TypeMapping {
export class DataStreamTimestamp {
enabled: boolean
}

/**
* @es_quirk This enum is a boolean that evolved into a tri-state enum. True and False have
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: Out of curiosity, does ES accept true and false as string too? This seems to be the case for the other enums evolved from a boolean.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pquentin pquentin merged commit a88eef2 into main Mar 5, 2025
14 checks passed
@pquentin pquentin deleted the subobjects-auto branch March 5, 2025 09:33
github-actions bot pushed a commit that referenced this pull request Mar 5, 2025
(cherry picked from commit a88eef2)
github-actions bot pushed a commit that referenced this pull request Mar 5, 2025
(cherry picked from commit a88eef2)
github-actions bot pushed a commit that referenced this pull request Mar 5, 2025
(cherry picked from commit a88eef2)
pquentin added a commit that referenced this pull request Mar 5, 2025
(cherry picked from commit a88eef2)

Co-authored-by: Quentin Pradet <[email protected]>
pquentin added a commit that referenced this pull request Mar 5, 2025
(cherry picked from commit a88eef2)

Co-authored-by: Quentin Pradet <[email protected]>
pquentin added a commit that referenced this pull request Mar 5, 2025
(cherry picked from commit a88eef2)

Co-authored-by: Quentin Pradet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants