-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support subobjects: auto #3877
Support subobjects: auto #3877
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -59,3 +59,16 @@ export class TypeMapping { | |||
export class DataStreamTimestamp { | |||
enabled: boolean | |||
} | |||
|
|||
/** | |||
* @es_quirk This enum is a boolean that evolved into a tri-state enum. True and False have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: Out of curiosity, does ES accept true
and false
as string too? This seems to be the case for the other enums evolved from a boolean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(cherry picked from commit a88eef2)
(cherry picked from commit a88eef2)
(cherry picked from commit a88eef2)
(cherry picked from commit a88eef2) Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit a88eef2) Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit a88eef2) Co-authored-by: Quentin Pradet <[email protected]>
This fixes validation for
cluster.put_component_template
.