-
Notifications
You must be signed in to change notification settings - Fork 25k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
…120475) This expands the `TranslationAware` interface for expressions that support translations to Lucene query and moves the implementations of these translations from a centralised place (ExpressionTranslators) to the respective expression classes. `TranslationAware` has now a subinterface, `SingleValueTranslationAware`, for expressions that need to implement the single-value logic (`null` out on MVs). So the `SingleValueQuery` wrapping no longer needs to be performed explicitly by the implementer. `TranslationAware` is now part of the `org.elasticsearch.xpack.esql.capabilities` package, together with the other interfaces that extensions needs to implement to be used by the core services (verifier and optimizer). To allow this, some logical nodes have been moved from core in the ESQL proper (where also `LucenePushdownPredicates` resides, used by `TranslationAware`). (cherry picked from commit a867127)
- Loading branch information
Showing
91 changed files
with
1,178 additions
and
1,284 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
pr: 120192 | ||
summary: Extend `TranslationAware` to all pushable expressions | ||
area: ES|QL | ||
type: enhancement | ||
issues: [] |
20 changes: 0 additions & 20 deletions
20
...sql-core/src/main/java/org/elasticsearch/xpack/esql/core/expression/TranslationAware.java
This file was deleted.
Oops, something went wrong.
65 changes: 0 additions & 65 deletions
65
...main/java/org/elasticsearch/xpack/esql/core/expression/predicate/logical/BinaryLogic.java
This file was deleted.
Oops, something went wrong.
48 changes: 0 additions & 48 deletions
48
...ql-core/src/main/java/org/elasticsearch/xpack/esql/core/planner/ExpressionTranslator.java
This file was deleted.
Oops, something went wrong.
165 changes: 0 additions & 165 deletions
165
...l-core/src/main/java/org/elasticsearch/xpack/esql/core/planner/ExpressionTranslators.java
This file was deleted.
Oops, something went wrong.
36 changes: 0 additions & 36 deletions
36
.../esql-core/src/main/java/org/elasticsearch/xpack/esql/core/planner/TranslatorHandler.java
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.