Add source api block set to reindex data stream index action params #119991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v9.0.0
needs:triage
parkertimmins
added
:Data Management/Data streams
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Hi @parkertimmins, I've created a changelog YAML for you. |
masseyke
reviewed
Jan 10, 2025
| } | ||
|
|
||
| @Override | ||
| protected Request mutateInstance(Request instance) { | ||
| return new ReindexDataStreamIndexAction.Request(randomValueOtherThan(instance.getSourceIndex(), () -> randomAlphaOfLength(20))); | ||
| return new ReindexDataStreamIndexAction.Request( |
There was a problem hiding this comment.
I think you just want to change one thing at a time here, so that we know that any single change causes the objects to not be equal.
masseyke
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a parameter to the reindex-datastream-index action containing the set of api blocks set on the source index before the reindex operation is called. This set will be stored in the task state for the reindex-datastream task and passed into each per-index action call.
Because the task may need to retry the per-index action for a given index, and the per-index action call could modify the api blocks on the source index, the api block set before the the first call is stored in the task state. This allows the correct original api blocks from the source index to be copied to the destination index after reindexing completes.