Updated description on ssl nodes in package level manifest.yml for files owned by obs-infraobs-integrations #12780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StacieClark-Elastic
force-pushed
the
bugfix/update-ssl-option-descriptions-package-manifest-obs-infraobs-integrations-12708
branch
from
42ba74b to
198be97
Compare
StacieClark-Elastic
added
Integration:system
|
Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform) |
|
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
|
Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform) |
🚀 Benchmarks reportTo see the full report comment with |
StacieClark-Elastic
force-pushed
the
bugfix/update-ssl-option-descriptions-package-manifest-obs-infraobs-integrations-12708
branch
from
198be97 to
d398cff
Compare
jrmolin
approved these changes
Feb 20, 2025
|
/test |
nfritts
approved these changes
Feb 27, 2025
intxgo
approved these changes
Feb 27, 2025
ishleenk17
reviewed
Feb 28, 2025
packages/activemq/manifest.yml
Outdated
| @@ -111,7 +111,7 @@ policy_templates: | |||
| # xw23l/k8RoD1wRWaDVbgpjwSzt+kl+vJE/ip2w3h69eEZ9wbo6scRO5lCO2JM4Pr | |||
| # 7RhLQyWn2u00L7/9Omw= | |||
| # -----END CERTIFICATE----- | |||
| description: i.e. certificate_authorities, supported_protocols, verification_mode etc. | |||
| description: SSL configuration options. See [documentation](https://www.elastic.co/guide/en/beats/metricbeat/current/configuration-ssl.html#ssl-common-config) for details. | |||
There was a problem hiding this comment.
It would be better if we use the Agent link here
https://www.elastic.co/guide/en/fleet/current/elastic-agent-ssl-configuration.html
ishleenk17
reviewed
Mar 1, 2025
StacieClark-Elastic
force-pushed
the
bugfix/update-ssl-option-descriptions-package-manifest-obs-infraobs-integrations-12708
branch
2 times, most recently
from
159d9fc to
5ef26ab
Compare
|
/test |
1 similar comment
|
/test |
Updates description field on ssl nodes in package level manifest.yml file to include links to online documentation and to be consistent with other integrations. This issue tracks changes to integration owned by obs-infraobs-integrations
…ntegrations-12708 changed link to agent documentation for activemq
…ntegrations-12708 changed links to point to elastic agent documentation
StacieClark-Elastic
force-pushed
the
bugfix/update-ssl-option-descriptions-package-manifest-obs-infraobs-integrations-12708
branch
from
5ef26ab to
7995f34
Compare
|
/test |
💚 Build Succeeded
History
|
|
ishleenk17
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Updates description field on ssl nodes in package level manifest.yml file to include links to online documentation and to be consistent with other integrations. This issue tracks changes to integration owned by obs-infraobs-integrations
Checklist
changelog.ymlfile.How to test this PR locally
Originally, we updated the descriptions on all the files in integration. This created some issues with so many teams needing to validate the files. This is currently a partial update with files that are owned by obs-infraobs-integrations,
git diff main | grep description: | grep + | sort -u
results in the update fields for the ssl node description and the changelog.yml
Related issues