-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
entityanalytics_okta: split user and device data into their own data streams #12798
Conversation
…ta streams This retains user data behaviour, routing non-user data in to the new entity data stream. This allows device data to be routed to a to-be-added device data stream.
1467f40
to
9328a62
Compare
🚀 Benchmarks reportTo see the full report comment with |
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
packages/entityanalytics_okta/data_stream/entity/sample_event.json
Outdated
Show resolved
Hide resolved
5691c6e
to
1f6024d
Compare
1f6024d
to
d746cda
Compare
Upgrade path is bumpy. Investigating. |
inputs: | ||
- type: entity-analytics | ||
title: Collect device identities | ||
description: Collecting device identities from Okta. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the Add Integration page, I see three separate inputs. I think that in this file we should only have one instance of the entity-analytics
input on the entity data stream.
inputs: | |
- type: entity-analytics | |
title: Collect device identities | |
description: Collecting device identities from Okta. |
@@ -6,6 +6,12 @@ This [Okta Entity Analytics](https://www.okta.com/) integration allows users to | |||
|
|||
This module has been tested against the Core Okta API version **v1**. | |||
|
|||
## Upgrading to v2 from v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a thought:
Should we rename v1
and v2
to 1.x
and 2.x
, or users infer them anyway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm finding it hard to get my brain into a state where v1 is not 1.x and v2 is not 2.x, though I do see that v1 is used immediately above referring to the API, so I will add, "of the integration" to the end of the sentence.
|
||
In v2 of the integration the user and device data was split into separate data streams. The data ingested into your index will be the same but you may need to update device searches if you were using them. | ||
|
||
**NOTE**: When you upgrade from v1 you will need to reconfigure the integration and enable it due to internal changes in the package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably a link to https://www.elastic.co/guide/en/fleet/current/upgrade-integration.html#resolve-conflicts might be helpful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue is not that fields fail to match, it's that the configuration is no longer visible since the name of the policy that holds it has changed, but I will add that link.
a9d3d70
to
1c587ac
Compare
💚 Build Succeeded
History
cc @efd6 |
|
Package entityanalytics_okta - 2.0.0 containing this change is available at https://epr.elastic.co/package/entityanalytics_okta/2.0.0/ |
Proposed commit message
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots