Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssi_all: update Kibana version constraint to support 9.0 #12919

Merged
merged 4 commits into from
Mar 4, 2025
Merged

ssi_all: update Kibana version constraint to support 9.0 #12919

merged 4 commits into from
Mar 4, 2025

Conversation

chemamartinez
Copy link
Contributor

Proposed commit message

Updated minor version and Kibana constraints to support 9.0 for all packages owned by the Security Service Integrations team, except for the ones already updated at #12593, and the ones listed at #11775 which are still pending for some breaking changes.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

@chemamartinez chemamartinez added enhancement New feature or request Integration:All Applies to all integrations [Integration not found in source] Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] labels Feb 27, 2025
@chemamartinez chemamartinez self-assigned this Feb 27, 2025
@chemamartinez chemamartinez marked this pull request as ready for review February 27, 2025 15:53
@chemamartinez chemamartinez requested review from a team as code owners February 27, 2025 15:53
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Feb 27, 2025 •
edited
Loading

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @chemamartinez

kcreddy
kcreddy approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified no package from #11775 (comment) is added to this PR.

@shashank-elastic shashank-elastic mentioned this pull request Mar 3, 2025
Open
8 tasks
ishleenk17
ishleenk17 reviewed Mar 4, 2025
View reviewed changes
packages/1password/changelog.yml
@@ -1,4 +1,9 @@
# newer versions go on top
- version: "1.32.0"
changes:
- description: Update Kibana constraint to support 9.0.0.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- description: Update Kibana constraint to support 9.0.0.
- description: Add Kibana constraint to support 9.0.0.

Its better to have this changelog, since we are not updating, but adding 9.0.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The kibana constraint is being modified to add the 9.0.0 semver clause. I think update matches this.

@ishleenk17
Copy link
Contributor

Have we run the CI against 9.0.0 ?
By default the CI would run for the minimum kibana version which will 8.x for these Integrations.

@efd6
Copy link
Contributor

efd6 commented Mar 4, 2025

The daily 9.0.0-SNAPSHOT tests do run against 9.

@andrewkroh
Copy link
Member

It should be possible to trigger a test of a specific stack version via comment

integrations/.buildkite/pull-requests.json

Line 28 in 279f1fe

"trigger_comment_regex": "^/test stack (7|8|9)\\.\\d+\\.\\d+(-SNAPSHOT)?$",

@ishleenk17
Copy link
Contributor

It should be possible to trigger a test of a specific stack version via comment

integrations/.buildkite/pull-requests.json

Line 28 in 279f1fe

"trigger_comment_regex": "^/test stack (7|8|9)\\.\\d+\\.\\d+(-SNAPSHOT)?$",

Yes thats how we also tested

/test stack 9.0.0-SNAPSHOT

@ishleenk17
Copy link
Contributor

The daily 9.0.0-SNAPSHOT tests do run against 9.

That would not run for these PR's I suppose.
We should run it by /test stack 9.0.0-SNAPSHOT

@efd6
Copy link
Contributor

efd6 commented Mar 4, 2025 •
edited
Loading

That would not run for these PR's I suppose.

Yeah, it would not run against these, but the tests that would run are functionally identical since these changes all only change the changelog and the kibana.version, the first of which has no effect and the second which is only constraining the kibana version, so moot in the daily 9.0.0-SNAPSHOT tests, since it's ignoring that.

@efd6
Copy link
Contributor

efd6 commented Mar 4, 2025

/test stack 9.0.0-SNAPSHOT

@efd6 efd6 enabled auto-merge (squash) March 4, 2025 08:20
@efd6 efd6 disabled auto-merge March 4, 2025 08:20
@elasticmachine
Copy link

💚 Build Succeeded

cc @chemamartinez

@efd6
Copy link
Contributor

efd6 commented Mar 4, 2025

Failure is unrelated flake:

025/03/04 08:36:08 DEBUG DELETE https://127.0.0.1:5601/api/fleet/epm/packages/abnormal_security/1.4.0
Error: error running package system tests: could not complete test run: dump failed: can't dump Elastic stack logs: can't copy internal logs (service: fleet-server): could not create docker compose project: unable to determine Docker Compose version: running Docker Compose version command failed: failed to start command with pseudo-tty: fork/exec /usr/bin/docker: operation not permitted
[abnormal_security] run_tests_package failed

@jsoriano Do you have any idea why this happens (I think I've seen it before).

@efd6
Copy link
Contributor

efd6 commented Mar 4, 2025

/test stack 9.0.0-SNAPSHOT

@efd6 efd6 enabled auto-merge (squash) March 4, 2025 09:54
@elastic-vault-github-plugin-prod
Copy link

Package ti_abusech - 2.6.0 containing this change is available at https://epr.elastic.co/package/ti_abusech/2.6.0/

@elastic-vault-github-plugin-prod
Copy link

Package ti_cif3 - 1.17.0 containing this change is available at https://epr.elastic.co/package/ti_cif3/1.17.0/

@elastic-vault-github-plugin-prod
Copy link

Package ti_crowdstrike - 2.4.0 containing this change is available at https://epr.elastic.co/package/ti_crowdstrike/2.4.0/

@elastic-vault-github-plugin-prod
Copy link

Package ti_cybersixgill - 1.33.0 containing this change is available at https://epr.elastic.co/package/ti_cybersixgill/1.33.0/

@elastic-vault-github-plugin-prod
Copy link

Package ti_domaintools - 0.2.0 containing this change is available at https://epr.elastic.co/package/ti_domaintools/0.2.0/

@elastic-vault-github-plugin-prod
Copy link

Package ti_eclecticiq - 1.4.0 containing this change is available at https://epr.elastic.co/package/ti_eclecticiq/1.4.0/

@elastic-vault-github-plugin-prod
Copy link

Package ti_eset - 1.6.0 containing this change is available at https://epr.elastic.co/package/ti_eset/1.6.0/

@elastic-vault-github-plugin-prod
Copy link

Package ti_maltiverse - 1.5.0 containing this change is available at https://epr.elastic.co/package/ti_maltiverse/1.5.0/

@elastic-vault-github-plugin-prod
Copy link

Package ti_mandiant_advantage - 1.9.0 containing this change is available at https://epr.elastic.co/package/ti_mandiant_advantage/1.9.0/

@elastic-vault-github-plugin-prod
Copy link

Package ti_misp - 1.38.0 containing this change is available at https://epr.elastic.co/package/ti_misp/1.38.0/

@elastic-vault-github-plugin-prod
Copy link

Package ti_opencti - 2.6.0 containing this change is available at https://epr.elastic.co/package/ti_opencti/2.6.0/

@elastic-vault-github-plugin-prod
Copy link

Package ti_otx - 1.28.0 containing this change is available at https://epr.elastic.co/package/ti_otx/1.28.0/

@elastic-vault-github-plugin-prod
Copy link

Package ti_rapid7_threat_command - 2.4.0 containing this change is available at https://epr.elastic.co/package/ti_rapid7_threat_command/2.4.0/

@elastic-vault-github-plugin-prod
Copy link

Package ti_recordedfuture - 1.29.0 containing this change is available at https://epr.elastic.co/package/ti_recordedfuture/1.29.0/

@elastic-vault-github-plugin-prod
Copy link

Package ti_threatconnect - 1.8.0 containing this change is available at https://epr.elastic.co/package/ti_threatconnect/1.8.0/

@elastic-vault-github-plugin-prod
Copy link

Package ti_threatq - 1.31.0 containing this change is available at https://epr.elastic.co/package/ti_threatq/1.31.0/

@elastic-vault-github-plugin-prod
Copy link

Package ti_util - 1.7.0 containing this change is available at https://epr.elastic.co/package/ti_util/1.7.0/

@elastic-vault-github-plugin-prod
Copy link

Package tines - 1.15.0 containing this change is available at https://epr.elastic.co/package/tines/1.15.0/

@elastic-vault-github-plugin-prod
Copy link

Package trellix_edr_cloud - 1.7.0 containing this change is available at https://epr.elastic.co/package/trellix_edr_cloud/1.7.0/

@elastic-vault-github-plugin-prod
Copy link

Package trellix_epo_cloud - 1.15.0 containing this change is available at https://epr.elastic.co/package/trellix_epo_cloud/1.15.0/

@elastic-vault-github-plugin-prod
Copy link

Package trend_micro_vision_one - 1.26.0 containing this change is available at https://epr.elastic.co/package/trend_micro_vision_one/1.26.0/

@elastic-vault-github-plugin-prod
Copy link

Package trendmicro - 2.7.0 containing this change is available at https://epr.elastic.co/package/trendmicro/2.7.0/

@elastic-vault-github-plugin-prod
Copy link

Package tychon - 0.3.0 containing this change is available at https://epr.elastic.co/package/tychon/0.3.0/

@elastic-vault-github-plugin-prod
Copy link

Package vectra_detect - 1.13.0 containing this change is available at https://epr.elastic.co/package/vectra_detect/1.13.0/

@elastic-vault-github-plugin-prod
Copy link

Package websocket - 0.2.0 containing this change is available at https://epr.elastic.co/package/websocket/0.2.0/

@elastic-vault-github-plugin-prod
Copy link

Package zerofox - 1.28.0 containing this change is available at https://epr.elastic.co/package/zerofox/1.28.0/

@elastic-vault-github-plugin-prod
Copy link

Package zeronetworks - 1.18.0 containing this change is available at https://epr.elastic.co/package/zeronetworks/1.18.0/

@elastic-vault-github-plugin-prod
Copy link

Package zoom - 1.22.0 containing this change is available at https://epr.elastic.co/package/zoom/1.22.0/

@elastic-vault-github-plugin-prod
Copy link

Package zscaler_zpa - 1.21.0 containing this change is available at https://epr.elastic.co/package/zscaler_zpa/1.21.0/

@chemamartinez chemamartinez deleted the ssi-update-kibana-version-9.0.0 branch March 5, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

@ishleenk17 ishleenk17 ishleenk17 left review comments

@kcreddy kcreddy kcreddy approved these changes

Assignees

@chemamartinez chemamartinez

Labels
enhancement New feature or request Integration:All Applies to all integrations [Integration not found in source] Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chemamartinez @elasticmachine @ishleenk17 @efd6 @andrewkroh @kcreddy