Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http_endpoint: improve HMAC config documentation #12942

Merged
merged 1 commit into from
Mar 4, 2025
Merged

http_endpoint: improve HMAC config documentation #12942

merged 1 commit into from
Mar 4, 2025

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Mar 3, 2025 •
edited
Loading

Proposed commit message

http_endpoint: improve HMAC config documentation

The documentation did not indicate the types of HMAC headers that are
accepted by the integration. Base64 header support (raw and std encoding)
was added to the input in v8.15, so in order to not mislead users, the
kibana version is bumped to that.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Integration:http_endpoint Custom HTTP Endpoint Logs Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] labels Mar 3, 2025
@efd6 efd6 self-assigned this Mar 3, 2025
@efd6 efd6 force-pushed the id416-http_endpoint branch from 093da6e to fcba7e8 Compare March 3, 2025 20:48
@efd6 efd6 marked this pull request as ready for review March 3, 2025 21:28
@efd6 efd6 requested a review from a team as a code owner March 3, 2025 21:28
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@efd6 efd6 force-pushed the id416-http_endpoint branch from fcba7e8 to 023f5f4 Compare March 4, 2025 00:35
@efd6 efd6 mentioned this pull request Mar 4, 2025
Merged
5 tasks
@efd6
http_endpoint: improve HMAC config documentation
dc90b0a 
The documentation did not indicate the types of HMAC headers that are
accepted by the integration. Base64 header support (raw and std encoding)
was added to the input in v8.15, so in order to not mislead users, the
kibana version is bumped to that.
@efd6 efd6 force-pushed the id416-http_endpoint branch from 023f5f4 to dc90b0a Compare March 4, 2025 01:22
@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

History

  • 💚 Build #22938 succeeded 023f5f49849299b997e5a29e25c5ffec9204b916
  • 💚 Build #22930 succeeded fcba7e85778084e4b5955e3f98f7375950b78d22
  • 💔 Build #22927 failed 093da6e36d06908ff3c53faa920723e022adeb6e

cc @efd6

andrewkroh
andrewkroh approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit 279f1fe into elastic:main Mar 4, 2025
7 checks passed
@elastic-vault-github-plugin-prod
Copy link

Package http_endpoint - 2.4.0 containing this change is available at https://epr.elastic.co/package/http_endpoint/2.4.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees

@efd6 efd6

Labels
enhancement New feature or request Integration:http_endpoint Custom HTTP Endpoint Logs Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efd6 @elasticmachine @andrewkroh