Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Index Management] Skip failing test for forward compatibility scenario #211219

Open
wants to merge 6 commits into
base: 8.x
Choose a base branch
from
Open

[Index Management] Skip failing test for forward compatibility scenario #211219

wants to merge 6 commits into from

Conversation

sabarasaba
Copy link
Member

Addresses #208873

@sabarasaba sabarasaba self-assigned this Feb 14, 2025
@sabarasaba sabarasaba added Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting backport:prev-major Backport to (8.x, 8.18, 8.17, 8.16) the previous major branch and other branches in development and removed backport:prev-major Backport to (8.x, 8.18, 8.17, 8.16) the previous major branch and other branches in development labels Feb 14, 2025
@sabarasaba sabarasaba changed the title --cached [Index Management] Skip failing test for forward compatibility scenario Feb 14, 2025
@sabarasaba sabarasaba mentioned this pull request Feb 14, 2025
Closed
@sabarasaba sabarasaba requested a review from a team February 14, 2025 15:16
@sabarasaba sabarasaba marked this pull request as ready for review February 14, 2025 15:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

mattkime
mattkime reviewed Feb 14, 2025
View reviewed changes
x-pack/test/api_integration/apis/management/index_management/settings.ts Outdated
'max_shingle_diff',
'query_string',
];

it('should fetch an index settings', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be set to run only against 8

@sabarasaba
Copy link
Member Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 15, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #70 / management index management settings should fetch an index settings
  • [job] [logs] FTR Configs #70 / management index management settings should fetch an index settings

Metrics [docs]

✅ unchanged

History

cc @sabarasaba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattkime mattkime mattkime left review comments

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@sabarasaba sabarasaba

Labels
backport:skip This commit does not require backporting Feature:Index Management Index and index templates UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sabarasaba @elasticmachine @mattkime @kibanamachine