Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Index Management] Skip failing test for forward compatibility scenario #211219

Merged
merged 8 commits into from
Feb 18, 2025
Merged

[Index Management] Skip failing test for forward compatibility scenario #211219

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
19a11ef
--cached
sabarasaba Feb 14, 2025
f71b054
commit with @elastic email
sabarasaba Feb 14, 2025
d2f9fc6
Ensure the test only runs once for each major
sabarasaba Feb 15, 2025
532bf95
Dont use arrow function
sabarasaba Feb 15, 2025
95a6602
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine Feb 15, 2025
50caeee
Merge branch '8.x' into index_management-fix_test_forwardcompatibility_9
elasticmachine Feb 15, 2025
5422119
Wrap around describe
sabarasaba Feb 16, 2025
7de82b0
Merge branch '8.x' into index_management-fix_test_forwardcompatibility_9
elasticmachine Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
137 changes: 82 additions & 55 deletions x-pack/test/api_integration/apis/management/index_management/settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,60 @@ export default function ({ getService }: FtrProviderContext) {
describe('settings', () => {
after(async () => await deleteAllIndices());

const expectedIndexSettings = [
'max_inner_result_window',
'unassigned',
'max_terms_count',
'lifecycle',
'routing_partition_size',
'max_docvalue_fields_search',
'merge',
'max_refresh_listeners',
'max_regex_length',
'load_fixed_bitset_filters_eagerly',
'number_of_routing_shards',
'write',
'verified_before_close',
'mapping',
'source_only',
'soft_deletes',
'max_script_fields',
'query',
'format',
'frozen',
'sort',
'priority',
'codec',
'max_rescore_window',
'analyze',
'gc_deletes',
'max_ngram_diff',
'translog',
'auto_expand_replicas',
'requests',
'data_path',
'highlight',
'routing',
'search',
'fielddata',
'default_pipeline',
'max_slices_per_scroll',
'shard',
'xpack',
'percolator',
'allocation',
'refresh_interval',
'indexing',
'compound_format',
'blocks',
'max_result_window',
'store',
'queries',
'warmer',
'max_shingle_diff',
'query_string',
];

it('should fetch an index settings', async () => {
sabarasaba marked this conversation as resolved.
Show resolved Hide resolved
const index = await createIndex();

Expand All @@ -27,62 +81,8 @@ export default function ({ getService }: FtrProviderContext) {
// Verify we fetch the corret index settings
expect(body.settings.index.provided_name).to.be(index);

const expectedSettings = [
'max_inner_result_window',
'unassigned',
'max_terms_count',
'lifecycle',
'routing_partition_size',
'max_docvalue_fields_search',
'merge',
'max_refresh_listeners',
'max_regex_length',
'load_fixed_bitset_filters_eagerly',
'number_of_routing_shards',
'write',
'verified_before_close',
'mapping',
'source_only',
'soft_deletes',
'max_script_fields',
'query',
'format',
'frozen',
'sort',
'priority',
'codec',
'max_rescore_window',
'analyze',
'gc_deletes',
'max_ngram_diff',
'translog',
'auto_expand_replicas',
'requests',
'data_path',
'highlight',
'routing',
'search',
'fielddata',
'default_pipeline',
'max_slices_per_scroll',
'shard',
'xpack',
'percolator',
'allocation',
'refresh_interval',
'indexing',
'compound_format',
'blocks',
'max_result_window',
'store',
'queries',
'warmer',
'max_shingle_diff',
'query_string',
];

// Make sure none of the settings have been removed from ES API
expectedSettings.forEach((setting) => {
expectedIndexSettings.forEach((setting) => {
try {
expect(Object.hasOwn(body.defaults.index, setting)).to.be(true);
} catch {
Expand All @@ -91,6 +91,33 @@ export default function ({ getService }: FtrProviderContext) {
});
});

describe('Forward compatibility with 9.x', function () {
this.onlyEsVersion('>=9');

it('should fetch an index settings', async () => {
const indexSettingsNotIn9 = ['frozen'];

const index = await createIndex();

const { status, body } = await getIndexSettings(index);
expect(status).to.eql(200);

// Verify we fetch the corret index settings
expect(body.settings.index.provided_name).to.be(index);

// Make sure none of the settings have been removed from ES API
expectedIndexSettings
.filter((setting) => !indexSettingsNotIn9.includes(setting))
.forEach((setting) => {
try {
expect(Object.hasOwn(body.defaults.index, setting)).to.be(true);
} catch {
throw new Error(`Expected setting "${setting}" not found.`);
}
});
});
});

it('should update an index settings', async () => {
const index = await createIndex();

Expand Down