-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade EUI to v92.0.0 #174487
Upgrade EUI to v92.0.0 #174487
Changes from 6 commits
08408bf
d265e07
f4186b3
c2a83c8
f16ed50
cff9b40
9b62f1b
0149a4d
11a9924
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -102,7 +102,7 @@ | |
"@elastic/datemath": "5.0.3", | ||
"@elastic/elasticsearch": "npm:@elastic/[email protected]", | ||
"@elastic/ems-client": "8.5.1", | ||
"@elastic/eui": "91.3.1", | ||
"@elastic/eui": "92.0.0-backport.0", | ||
"@elastic/filesaver": "1.1.2", | ||
"@elastic/node-crypto": "1.2.1", | ||
"@elastic/numeral": "^2.5.1", | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -85,7 +85,7 @@ export const LICENSE_OVERRIDES = { | |
'[email protected]': ['Eclipse Distribution License - v 1.0'], // cf. https://github.com/bjornharrtell/jsts | ||
'@mapbox/[email protected]': ['MIT'], // license in readme https://github.com/tmcw/jsonlint | ||
'@elastic/[email protected]': ['Elastic License 2.0'], | ||
'@elastic/eui@91.3.1': ['SSPL-1.0 OR Elastic License 2.0'], | ||
'@elastic/eui@92.0.0-backport.0': ['SSPL-1.0 OR Elastic License 2.0'], | ||
'[email protected]': ['CC-BY-4.0'], // retired ODC‑By license https://github.com/mattcg/language-subtag-registry | ||
'[email protected]': ['MIT'], // license in importing module https://www.npmjs.com/package/binary | ||
'@bufbuild/[email protected]': ['Apache-2.0'], // license (Apache-2.0 AND BSD-3-Clause) | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -51,7 +51,6 @@ interface RiskScoreFieldProps { | |
idAria: string; | ||
indices: DataViewBase; | ||
isDisabled: boolean; | ||
isActive: boolean; | ||
placeholder?: string; | ||
} | ||
|
||
|
@@ -61,7 +60,6 @@ export const RiskScoreField = ({ | |
idAria, | ||
indices, | ||
isDisabled, | ||
isActive, | ||
placeholder, | ||
}: RiskScoreFieldProps) => { | ||
const { value, isMappingChecked, mapping } = field.value; | ||
|
@@ -149,39 +147,29 @@ export const RiskScoreField = ({ | |
return ( | ||
<EuiFlexGroup direction={'column'}> | ||
<EuiFlexItem> | ||
{ | ||
// TODO: https://github.com/elastic/kibana/issues/161456 | ||
// The About step page contains EuiRange component which does not work properly within memoized parents. | ||
// EUI team suggested not to memoize EuiRange/EuiDualRange: https://github.com/elastic/eui/issues/6846 | ||
// Workaround: We force EuiRange re-rendering by removing/adding it into the DOM. | ||
// NOTE: We should remove this workaround once EUI team fixed EuiRange. | ||
// Related ticket: https://github.com/elastic/kibana/issues/160561 | ||
} | ||
{isActive && ( | ||
<EuiFormRow | ||
Comment on lines
-153
to
-161
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @e40pud I tested this locally and it appears to be working for me, but would super appreciate a second confirmation/QA! ✨ There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Tested locally. There is no issue anymore! Thanks for fixing this!! |
||
label={riskScoreLabel} | ||
labelAppend={field.labelAppend} | ||
helpText={field.helpText} | ||
error={'errorMessage'} | ||
isInvalid={false} | ||
fullWidth | ||
data-test-subj={`${dataTestSubj}-defaultRisk`} | ||
describedByIds={idAria ? [idAria] : undefined} | ||
> | ||
<EuiRange | ||
value={value} | ||
onChange={handleDefaultRiskScoreChange} | ||
max={100} | ||
min={0} | ||
showRange | ||
showInput | ||
fullWidth={false} | ||
showTicks | ||
tickInterval={25} | ||
data-test-subj={`${dataTestSubj}-defaultRiskRange`} | ||
/> | ||
</EuiFormRow> | ||
)} | ||
<EuiFormRow | ||
label={riskScoreLabel} | ||
labelAppend={field.labelAppend} | ||
helpText={field.helpText} | ||
error={'errorMessage'} | ||
isInvalid={false} | ||
fullWidth | ||
data-test-subj={`${dataTestSubj}-defaultRisk`} | ||
describedByIds={idAria ? [idAria] : undefined} | ||
> | ||
<EuiRange | ||
value={value} | ||
onChange={handleDefaultRiskScoreChange} | ||
max={100} | ||
min={0} | ||
showRange | ||
showInput | ||
fullWidth={false} | ||
showTicks | ||
tickInterval={25} | ||
data-test-subj={`${dataTestSubj}-defaultRiskRange`} | ||
/> | ||
</EuiFormRow> | ||
</EuiFlexItem> | ||
<EuiFlexItem> | ||
<EuiFormRow | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ref and method call were removed because EuiDualRange now contains its own resize observer and automatically adjusts its width accordingly.