-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Profiling] Improve docs on how to manage storage #3247
[Profiling] Improve docs on how to manage storage #3247
Conversation
With this commit we restructure the Universal Profiling documentation and add a new menu item about managing storage. It contains a new section that explains how to customize the ILM policy (usually to customize the retention period or to take advantage of data tiers) and moves the probabilistic profiling documentation also into this section.
A documentation preview will be available soon: |
This pull request does not have a backport label. Could you fix it @danielmitterdorfer? 🙏
|
This documentation is aligned with https://www.elastic.co/guide/en/apm/guide/current/ilm-how-to.html. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions, let me know if you have any questions or comments.
|
||
Index lifecycle policies allow you to automate the lifecycle of your profiling indices as they grow and age. A default policy is applied, but can be customized depending on your business needs. | ||
|
||
See {ref}/index-lifecycle-management.html[Manage the index lifecycle] to learn more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See {ref}/index-lifecycle-management.html[Manage the index lifecycle] to learn more. |
We might want to hold off on the link to start the page unless we want the user to leave the page right away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I've moved the link now to a tip cd5341f which appears in the context of creating a custom policy.
docs/en/observability/profiling-index-lifecycle-management.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/observability/profiling-index-lifecycle-management.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/observability/profiling-index-lifecycle-management.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/observability/profiling-index-lifecycle-management.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/observability/profiling-index-lifecycle-management.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/observability/profiling-index-lifecycle-management.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/observability/profiling-index-lifecycle-management.asciidoc
Outdated
Show resolved
Hide resolved
…iidoc Co-authored-by: Mike Birnstiehl <[email protected]>
…iidoc Co-authored-by: Mike Birnstiehl <[email protected]>
…iidoc Co-authored-by: Mike Birnstiehl <[email protected]>
…iidoc Co-authored-by: Mike Birnstiehl <[email protected]>
…iidoc Co-authored-by: Mike Birnstiehl <[email protected]>
…iidoc Co-authored-by: Mike Birnstiehl <[email protected]>
…iidoc Co-authored-by: Mike Birnstiehl <[email protected]>
…iidoc Co-authored-by: Mike Birnstiehl <[email protected]>
Co-authored-by: Mike Birnstiehl <[email protected]>
…iidoc Co-authored-by: Mike Birnstiehl <[email protected]>
Co-authored-by: Mike Birnstiehl <[email protected]>
…iidoc Co-authored-by: Mike Birnstiehl <[email protected]>
…iidoc Co-authored-by: Mike Birnstiehl <[email protected]>
…iidoc Co-authored-by: Mike Birnstiehl <[email protected]>
…iidoc Co-authored-by: Mike Birnstiehl <[email protected]>
…iidoc Co-authored-by: Mike Birnstiehl <[email protected]>
…iidoc Co-authored-by: Mike Birnstiehl <[email protected]>
…iidoc Co-authored-by: Mike Birnstiehl <[email protected]>
Thanks for the review! I've applied the suggestions and moved the link to the ILM docs down where it can be read in the context of creating a new ILM policy. |
@@ -7,8 +7,6 @@ See the following sections for more information: | |||
* <<profiling-tag-data-query, Tag data for querying>>: Tag data collected by the host-agent into multiple logical groups so they can be queried in Kibana. | |||
* <<profiling-add-symbols, Add symbols for native frames>>: Push symbols to your cluster so you can see function names and line numbers in traces of applications written in programming languages that compile to native code (C, C++, Rust, Go, etc.). | |||
* <<profiling-use-a-proxy,Use a proxy>>: Set up an HTTP proxy if your infrastructure host-agent installation needs one to reach {ecloud}. | |||
* <<profiling-probabilistic-profiling, Configure probabilistic profiling>>: Configure the Universal Profiling agent to run in probabilistic profiling mode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a random fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. I've moved this intentionally because, related to ILM, probabilistic profiling can be used to control how much storage profiling requires.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
docs/en/observability/profiling-index-lifecycle-management.asciidoc
Outdated
Show resolved
Hide resolved
…iidoc Co-authored-by: Christos Kalkanis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one suggestion I missed the first time around, otherwise LGTM!
…iidoc Co-authored-by: Mike Birnstiehl <[email protected]>
e976631
With this commit we restructure the Universal Profiling documentation and add a new menu item about managing storage. It contains a new section that explains how to customize the ILM policy (usually to customize the retention period or to take advantage of data tiers) and moves the probabilistic profiling documentation also into this section.
Relates elastic/elasticsearch#99909