[APM] Add note about @custom component templates
#4200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colleenmcginnis
added
backport-8.14
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
bmorelli25
added
the
backport-8.x
|
👋 @marclop can you take a look at this PR sometime this week? |
marclop
reviewed
Sep 18, 2024
colleenmcginnis
commented
Sep 26, 2024
There was a problem hiding this comment.
Thanks for your input @axw @marclop! I attempted to capture your feedback in the latest commit, and I left some specific questions below. Here's the preview: Accessing the @metadata field.
axw
reviewed
Oct 8, 2024
colleenmcginnis
added a commit
that referenced
this pull request
Oct 9, 2024
* add note about custom component templates * attempt to address feedback * apply suggestions from @axw (cherry picked from commit 15dde46) Co-authored-by: Colleen McGinnis <[email protected]>
colleenmcginnis
added a commit
that referenced
this pull request
Oct 9, 2024
* add note about custom component templates * attempt to address feedback * apply suggestions from @axw (cherry picked from commit 15dde46) Co-authored-by: Colleen McGinnis <[email protected]>
colleenmcginnis
added a commit
that referenced
this pull request
Oct 9, 2024
* add note about custom component templates * attempt to address feedback * apply suggestions from @axw (cherry picked from commit 15dde46) Co-authored-by: Colleen McGinnis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes elastic/apm-server#11651
👋 @marclop it's not clear in the issue if this applies only to
[data_stream][dataset]or also totypeandnamespace, too.