Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alert history chart screenshots #4301

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

colleenmcginnis
Copy link
Contributor

@colleenmcginnis colleenmcginnis commented Sep 25, 2024

Description

Update alert history chart screenshots in the Triage SLO burn rate breaches (preview) and Triage threshold breaches (preview) pages.

This PR also makes a few other changes:

  • Splits screenshots into individual images for each chart to make it easier to maintain.
  • Attempts to make the list describing charts more browsable with bold text at the beginning.
  • Moves the last bullet point about timeline annotations to the first bullet point on both pages because (I think) with the change to the alert history chart, there are no longer annotations in alerts history.

Documentation sets edited in this PR

Check all that apply.

  • Stateful (docs/en/observability/*)
  • Serverless (docs/en/serverless/*)
  • Integrations Developer Guide (docs/en/integrations/*)
  • None of the above

Related issue

Closes #4129

Checklist

  • Product/Engineering Review
  • Writer Review
    (@dedemorton I'd be particularly interested in your opinion of the changes since I think you wrote the initial content)

Follow-up tasks

Select one.

  • This PR does not need to be ported to another doc set because:
    • The concepts in this PR only apply to one doc set (serverless or stateful)
    • The PR contains edits to both doc sets (serverless and stateful)
  • This PR needs to be ported to another doc set:

@colleenmcginnis colleenmcginnis added needs-writer-review backport-8.15 Automated backport with mergify backport-8.x Automated backport to the 8.x branch with mergify needs-product-review labels Sep 25, 2024
@colleenmcginnis colleenmcginnis self-assigned this Sep 25, 2024
@colleenmcginnis colleenmcginnis requested a review from a team as a code owner September 25, 2024 14:07
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Member

@maryam-saeidi maryam-saeidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from my perspective too

@colleenmcginnis colleenmcginnis mentioned this pull request Sep 30, 2024
6 tasks
@colleenmcginnis colleenmcginnis merged commit 42101a4 into elastic:main Sep 30, 2024
4 checks passed
@colleenmcginnis colleenmcginnis deleted the issue-4129 branch September 30, 2024 20:43
mergify bot pushed a commit that referenced this pull request Sep 30, 2024
* update triage threshold breaches pages

* update triage slo burn rate breaches page

* attempt to address feedback from @maryam-saeidi

(cherry picked from commit 42101a4)
mergify bot pushed a commit that referenced this pull request Sep 30, 2024
* update triage threshold breaches pages

* update triage slo burn rate breaches page

* attempt to address feedback from @maryam-saeidi

(cherry picked from commit 42101a4)
colleenmcginnis added a commit that referenced this pull request Sep 30, 2024
* update triage threshold breaches pages

* update triage slo burn rate breaches page

* attempt to address feedback from @maryam-saeidi

(cherry picked from commit 42101a4)

Co-authored-by: Colleen McGinnis <[email protected]>
colleenmcginnis added a commit that referenced this pull request Sep 30, 2024
* update triage threshold breaches pages

* update triage slo burn rate breaches page

* attempt to address feedback from @maryam-saeidi

(cherry picked from commit 42101a4)

Co-authored-by: Colleen McGinnis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.15 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request]: Update alert history chart screenshots
4 participants