Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Inventory] Remove the new services inventory docs #4342

Merged

Conversation

alaudazzi
Copy link
Contributor

@alaudazzi alaudazzi commented Oct 3, 2024

Description

This PR removes the new services inventory documentation as it is superseded by the new Inventory page (#4341) .

Documentation sets edited in this PR

Check all that apply.

  • Stateful (docs/en/observability/*)
  • Serverless (docs/en/serverless/*)
  • Integrations Developer Guide (docs/en/integrations/*)
  • None of the above

Related issues

Checklist

  • Product/Engineering Review
  • Writer Review

Follow-up tasks

Select one.

  • This PR does not need to be ported to another doc set because:
    • The concepts in this PR only apply to one doc set (serverless or stateful)
    • The PR contains edits to both doc sets (serverless and stateful)
  • This PR needs to be ported to another doc set:

Copy link
Contributor

mergify bot commented Oct 3, 2024

This pull request does not have a backport label. Could you fix it @alaudazzi? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Oct 3, 2024
roshan-elastic
roshan-elastic previously approved these changes Oct 3, 2024
Copy link
Contributor

@roshan-elastic roshan-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there are links to the page you deleted in two files that need to be updated or removed:

@alaudazzi
Copy link
Contributor Author

Thank you for your review @colleenmcginnis!
I updated the docs/en/serverless/apm/apm-ui-services.mdx by removing the reference for now. When we have more solid content for Inventory, we can put it back, if needed.

docs/en/serverless/elastic-entity-model.mdx is being updated in #4340, so broken links are expected.

Copy link
Contributor

@mdbirnstiehl mdbirnstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦭

@elasticdocs
Copy link

🚀 Built elastic-dot-co-docs-preview-docs successfully!

Issues? Visit #next-docs in Slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify needs-writer-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants