-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port #4341 to stateful docs: Add new page on inventory #4438
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
In the new Observability doc structure for 8.16, I've added the new Inventory page here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor things, otherwise LGTM. Thanks!
Co-authored-by: DeDe Morton <[email protected]>
@dedemorton
|
Edit: The problem is that you are looking at the wrong branch. Try navigating to the preview through the diff link so that you don't accidentally get dumped into the wrong branch from the landing page. Maybe it's a caching issues? Or maybe you got into the wrong branch by mistake and aren't looking at the preview? I can see the TOC entry here: |
I'm looking at your screenshots in the PR and they don't match what I see in the new navigation for 8.16 (see below). I'm looking at the latest snapshot build. But regardless, we should avoid including navigation in screen captures because it'll differ in 8.16 depending on whether users are looking at the new solution-based navigation or the "classic" navigation. The easy fix here is to just crop the page so that you don't show the navigation pane in the screenshot. |
@dedemorton |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* Add new page on inventory * Update docs/en/observability/apm/view-and-analyze/inventory.asciidoc Co-authored-by: DeDe Morton <[email protected]> * Crop images to remove nav pane --------- Co-authored-by: DeDe Morton <[email protected]> (cherry picked from commit c54a48d)
* Add new page on inventory * Update docs/en/observability/apm/view-and-analyze/inventory.asciidoc Co-authored-by: DeDe Morton <[email protected]> * Crop images to remove nav pane --------- Co-authored-by: DeDe Morton <[email protected]> (cherry picked from commit c54a48d)
* Add new page on inventory * Update docs/en/observability/apm/view-and-analyze/inventory.asciidoc Co-authored-by: DeDe Morton <[email protected]> * Crop images to remove nav pane --------- Co-authored-by: DeDe Morton <[email protected]> (cherry picked from commit c54a48d) Co-authored-by: Arianna Laudazzi <[email protected]>
* Add new page on inventory * Update docs/en/observability/apm/view-and-analyze/inventory.asciidoc Co-authored-by: DeDe Morton <[email protected]> * Crop images to remove nav pane --------- Co-authored-by: DeDe Morton <[email protected]> (cherry picked from commit c54a48d) Co-authored-by: Arianna Laudazzi <[email protected]>
…c#4438) * Add new page on inventory * Update docs/en/observability/apm/view-and-analyze/inventory.asciidoc Co-authored-by: DeDe Morton <[email protected]> * Crop images to remove nav pane --------- Co-authored-by: DeDe Morton <[email protected]>
Description
This PR adds a new page on Inventory (port #4341 to stateful docs).
Documentation sets edited in this PR
Check all that apply.
docs/en/observability/*
)docs/en/serverless/*
)docs/en/integrations/*
)Related issue
Closes #4348
Checklist
Follow-up tasks
Select one.
None apply, as this PR ports content from serverless to stateful.