Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MDX syntax, broken links, and use of the observability variable #4462

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

colleenmcginnis
Copy link
Contributor

Description

Fixes syntax errors, broken links, and updates based on the updated observability variable found while working on elastic/docs#3096.

Screenshot 2024-10-31 at 9 50 42 AM

(This will make it easier to pull in more updates ahead of finishing elastic/docs#3096.)

Documentation sets edited in this PR

Check all that apply.

  • Stateful (docs/en/observability/*)
  • Serverless (docs/en/serverless/*)
  • Integrations Developer Guide (docs/en/integrations/*)
  • None of the above

Related issue

N/A

Checklist

  • Product/Engineering Review
  • Writer Review

Follow-up tasks

Select one.

  • This PR does not need to be ported to another doc set because:
    • The concepts in this PR only apply to one doc set (serverless or stateful)
    • The PR contains edits to both doc sets (serverless and stateful)
  • This PR needs to be ported to another doc set:
    • Port to stateful docs: <link to PR or tracking issue>
    • Port to serverless docs: <link to PR or tracking issue>

@colleenmcginnis colleenmcginnis added backport-skip Skip notification from the automated backport with mergify needs-writer-review labels Oct 31, 2024
@colleenmcginnis colleenmcginnis self-assigned this Oct 31, 2024
@colleenmcginnis colleenmcginnis requested a review from a team as a code owner October 31, 2024 14:54
dedemorton
dedemorton previously approved these changes Oct 31, 2024
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM--just had a question.

I've eyeballed this (did not look at the preview).

docs/en/serverless/logging/troubleshoot-logs.mdx Outdated Show resolved Hide resolved
@elasticdocs
Copy link

elasticdocs commented Oct 31, 2024

🚀 Built elastic-dot-co-docs-preview-docs successfully!

Issues? Visit #next-docs in Slack

Copy link
Contributor Author

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to fix these in the script instead.

docs/en/serverless/alerting/view-alerts.mdx Outdated Show resolved Hide resolved
docs/en/serverless/logging/troubleshoot-logs.mdx Outdated Show resolved Hide resolved
docs/en/serverless/partials/roles.mdx Outdated Show resolved Hide resolved
docs/en/serverless/projects/billing.mdx Outdated Show resolved Hide resolved
docs/en/serverless/quickstarts/k8s-logs-metrics.mdx Outdated Show resolved Hide resolved
docs/en/serverless/synthetics/synthetics-feature-roles.mdx Outdated Show resolved Hide resolved
@colleenmcginnis
Copy link
Contributor Author

@dedemorton this is ready for a second look! (I pushed a commit so it dismissed your earlier approval.)

Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colleenmcginnis colleenmcginnis merged commit e36c836 into elastic:main Nov 1, 2024
5 checks passed
@colleenmcginnis colleenmcginnis deleted the mdx-fixes branch November 1, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify needs-writer-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants