Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stateful vs serverless attribute conflicts #4487

Merged
merged 5 commits into from
Nov 8, 2024

Conversation

colleenmcginnis
Copy link
Contributor

@colleenmcginnis colleenmcginnis commented Nov 6, 2024

⚠️ Do not merge before elastic/docs#3109 merges!

Description

Uses obs-serverless instead of observability in the serverless docs in most cases.

Documentation sets edited in this PR

Check all that apply.

  • Stateful (docs/en/observability/*)
  • Serverless (docs/en/serverless/*)
  • Integrations Developer Guide (docs/en/integrations/*)
  • None of the above

Related issue

N/A

Checklist

  • Product/Engineering Review
  • Writer Review

Follow-up tasks

Select one.

  • This PR does not need to be ported to another doc set because:
    • The concepts in this PR only apply to one doc set (serverless or stateful)
    • The PR contains edits to both doc sets (serverless and stateful)
  • This PR needs to be ported to another doc set:
    • Port to stateful docs: <link to PR or tracking issue>
    • Port to serverless docs: <link to PR or tracking issue>

@colleenmcginnis colleenmcginnis self-assigned this Nov 6, 2024
@colleenmcginnis colleenmcginnis requested a review from a team as a code owner November 6, 2024 14:26
Copy link
Contributor

github-actions bot commented Nov 6, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

This comment was marked as resolved.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Nov 6, 2024
bmorelli25
bmorelli25 previously approved these changes Nov 6, 2024
@colleenmcginnis colleenmcginnis marked this pull request as draft November 6, 2024 23:06
@colleenmcginnis

This comment was marked as outdated.

:doctype: book

include::{asciidoc-dir}/../../shared/versions/stack/master.asciidoc[]
include::{asciidoc-dir}/../../shared/versions/stack/current.asciidoc[]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I initially used master because I thought we wanted to link to the master version of stateful docs, but that messed up code blocks using version (example). 😬

@colleenmcginnis colleenmcginnis marked this pull request as ready for review November 8, 2024 14:23
@colleenmcginnis
Copy link
Contributor Author

For the reviewer: You can see the result of this change by going to this diff in the built-docs repo or looking at diff page and comparing the production link (example) to the preview link (example).

Production Preview
image image

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clicked around a bunch and LGTM!

@colleenmcginnis colleenmcginnis merged commit d3e87ce into elastic:main Nov 8, 2024
4 checks passed
@colleenmcginnis colleenmcginnis deleted the fix-attr branch November 8, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify needs-writer-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants