Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #4398) profiling: add documentation for the config file and CLI arguments #4499

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 7, 2024

Description

Extend the documentation about the format of the config file and the CLI arguments.

Documentation sets edited in this PR

Check all that apply.

  • Stateful (docs/en/observability/*)
  • Serverless (docs/en/serverless/*)
  • Integrations Developer Guide (docs/en/integrations/*)
  • None of the above

This is an automatic backport of pull request #4398 done by [Mergify](https://mergify.com).

…4398)

* profiling: add documentation for the config file

Signed-off-by: Florian Lehner <[email protected]>

* Apply suggestions from code review

Co-authored-by: Christos Kalkanis <[email protected]>

* Apply suggestions from code review

Co-authored-by: Christos Kalkanis <[email protected]>

* Apply suggestions from code review

Co-authored-by: Mike Birnstiehl <[email protected]>

---------

Signed-off-by: Florian Lehner <[email protected]>
Co-authored-by: Christos Kalkanis <[email protected]>
Co-authored-by: Mike Birnstiehl <[email protected]>
(cherry picked from commit e335f27)

# Conflicts:
#	docs/en/observability/index.asciidoc
#	docs/en/observability/profiling-envs.asciidoc
@mergify mergify bot requested a review from a team as a code owner November 7, 2024 14:06
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Nov 7, 2024
Copy link
Contributor Author

mergify bot commented Nov 7, 2024

Cherry-pick of e335f27 has failed:

On branch mergify/bp/8.x/pr-4398
Your branch is up to date with 'origin/8.x'.

You are currently cherry-picking commit e335f277.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   docs/en/observability/profiling-advanced-configuration.asciidoc
	new file:   docs/en/observability/profiling-config-file.asciidoc

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   docs/en/observability/index.asciidoc
	deleted by us:   docs/en/observability/profiling-envs.asciidoc

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor

github-actions bot commented Nov 7, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@florianl florianl enabled auto-merge (squash) November 7, 2024 14:11
@mdbirnstiehl mdbirnstiehl merged commit 553e9d7 into 8.x Nov 7, 2024
4 checks passed
@mdbirnstiehl mdbirnstiehl deleted the mergify/bp/8.x/pr-4398 branch November 7, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants