Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into 8.16 branch #49

Merged
merged 29 commits into from
Nov 8, 2024
Merged

Merge main into 8.16 branch #49

merged 29 commits into from
Nov 8, 2024

Conversation

rogercoll
Copy link
Contributor

No description provided.

eedugon and others added 29 commits October 30, 2024 16:33
k8s-otel: cert-manager integration information added
Signed-off-by: Tetiana Kravchenko <[email protected]>
…ributes

split k8sattributes/ecs processor: do not add any extra metadata
autoGenerateCert indented within admissionWebhooks
@rogercoll rogercoll requested a review from gizas November 7, 2024 15:17
Copy link
Contributor

@eedugon eedugon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have left a comment to double check that the other changes in values.yaml are expected.

@@ -852,7 +873,7 @@ collectors:
processors:
- elasticinframetrics
- batch
- k8sattributes
- k8sattributes/ecs
- resourcedetection/system
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rogercoll : these changes are not related with the autoGenerateCert change I did.
Just FYI.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, those changes were already merged. I think this is an issue with how GitHub shows the diffs, see the "two dot" difference instead: https://github.com/elastic/opentelemetry/compare/8.16..main

@rogercoll rogercoll merged commit 243b2f3 into 8.16 Nov 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants