Take-home project for Arthur Kay #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take-Home project
First, some screenshots:
All starships plotted:
Starships filtered by a selected film:
Tech notes
I used
mobxfor state management. Two "stores" can be found under/src/stores/that control the logic/data flow.Mobx integrates with React via
mobx-reactmagic (not unlike Redux), and you'll find those component bindings in the.tsxfiles.d3code was written by hand, rather than using a wrapping library. Some bugs persist with the placement of D3 elements (for example, the axis labels overlap the tick labels), but given the time constraints I'm hoping that is acceptable.CSS/design is also minimal, given time constraints.
I did not add any unit tests.